Skip to content

refactor: revert back to using proxy name#2307

Merged
graikhel-intel merged 1 commit into
mainfrom
proxyname
Sep 3, 2025
Merged

refactor: revert back to using proxy name#2307
graikhel-intel merged 1 commit into
mainfrom
proxyname

Conversation

@graikhel-intel

Copy link
Copy Markdown
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

@graikhel-intel
graikhel-intel force-pushed the proxyname branch 2 times, most recently from f324aeb to c9da32a Compare September 3, 2025 02:58
@graikhel-intel
graikhel-intel marked this pull request as ready for review September 3, 2025 03:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the proxy configuration naming scheme back to using proxyName as the primary identifier instead of accessInfo. The changes ensure consistent naming throughout the codebase and update the database schema to support the new naming convention.

Key changes:

  • Add proxyName field validation and restore it as the primary identifier for proxy configurations
  • Update database schema to use proxy_config_name as primary key instead of access_info
  • Refactor all database queries, API responses, and error handling to use the new naming convention

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/routes/admin/proxy/proxyValidator.ts Adds validation for proxyName field with alphanumeric and length constraints
src/routes/admin/proxy/create.ts Updates logging and error handling to use proxyName instead of accessInfo
src/routes/admin/profiles/amtProfileValidator.ts Changes proxy config validation to use profileName instead of configName
src/models/RCS.Config.ts Adds proxyName field to ProxyConfig interface and updates ProfileProxyConfigs
src/data/postgres/tables/proxyConfigs.ts Comprehensive refactor of all database operations to use proxy_config_name
src/data/postgres/tables/proxyConfigs.test.ts Updates all test cases to reflect the new naming convention
src/data/postgres/tables/profiles.ts Modifies SQL queries to use proxy_config_name in JSON aggregation
src/data/postgres/tables/profiles.test.ts Updates test expectations for the new query structure
src/data/postgres/tables/profileProxyConfigs.ts Refactors table operations to use proxy_config_name
src/data/postgres/tables/profileProxyConfigs.test.ts Updates test cases for the new column naming
data/init.sql Modifies database schema with new primary key and foreign key constraints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread data/init.sql
@graikhel-intel
graikhel-intel enabled auto-merge (squash) September 3, 2025 15:56
@graikhel-intel
graikhel-intel merged commit 121680e into main Sep 3, 2025
9 checks passed
@graikhel-intel
graikhel-intel deleted the proxyname branch September 3, 2025 17:08
@RosieAMT

RosieAMT commented Oct 8, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 2.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants