refactor: revert back to using proxy name#2307
Merged
Merged
Conversation
graikhel-intel
force-pushed
the
proxyname
branch
2 times, most recently
from
September 3, 2025 02:58
f324aeb to
c9da32a
Compare
graikhel-intel
force-pushed
the
proxyname
branch
from
September 3, 2025 03:00
c9da32a to
5a0be3b
Compare
graikhel-intel
marked this pull request as ready for review
September 3, 2025 03:07
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the proxy configuration naming scheme back to using proxyName as the primary identifier instead of accessInfo. The changes ensure consistent naming throughout the codebase and update the database schema to support the new naming convention.
Key changes:
- Add
proxyNamefield validation and restore it as the primary identifier for proxy configurations - Update database schema to use
proxy_config_nameas primary key instead ofaccess_info - Refactor all database queries, API responses, and error handling to use the new naming convention
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/routes/admin/proxy/proxyValidator.ts | Adds validation for proxyName field with alphanumeric and length constraints |
| src/routes/admin/proxy/create.ts | Updates logging and error handling to use proxyName instead of accessInfo |
| src/routes/admin/profiles/amtProfileValidator.ts | Changes proxy config validation to use profileName instead of configName |
| src/models/RCS.Config.ts | Adds proxyName field to ProxyConfig interface and updates ProfileProxyConfigs |
| src/data/postgres/tables/proxyConfigs.ts | Comprehensive refactor of all database operations to use proxy_config_name |
| src/data/postgres/tables/proxyConfigs.test.ts | Updates all test cases to reflect the new naming convention |
| src/data/postgres/tables/profiles.ts | Modifies SQL queries to use proxy_config_name in JSON aggregation |
| src/data/postgres/tables/profiles.test.ts | Updates test expectations for the new query structure |
| src/data/postgres/tables/profileProxyConfigs.ts | Refactors table operations to use proxy_config_name |
| src/data/postgres/tables/profileProxyConfigs.test.ts | Updates test cases for the new column naming |
| data/init.sql | Modifies database schema with new primary key and foreign key constraints |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
graikhel-intel
enabled auto-merge (squash)
September 3, 2025 15:56
madhavilosetty-intel
approved these changes
Sep 3, 2025
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )