refactor: user friendly name for proxy address#2318
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the proxy configuration API to use a more user-friendly field name by changing accessInfo to address for proxy server addresses.
- Renamed
accessInfofield toaddressthroughout the codebase for better clarity - Updated database schema to use
addresscolumn instead ofaccessInfo - Modified validation logic and test cases to reflect the new field name
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/collections/rps.postman_collection.json | Updated API test collection to use address field in requests and assertions |
| src/stateMachines/ciraConfiguration.ts | Changed AMT.Models.MPServer property from AccessInfo to address |
| src/routes/admin/proxy/proxyValidator.ts | Updated validation rules to check address field instead of accessInfo |
| src/models/RCS.Config.ts | Updated interface definitions and comments to use address terminology |
| src/data/postgres/tables/proxyConfigs.ts | Modified database queries to use address column and updated field mappings |
| src/data/postgres/tables/proxyConfigs.test.ts | Updated test cases to use address field in mock data and assertions |
| data/init.sql | Changed database schema to use address column and updated constraint names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rsdmike
force-pushed
the
proxyAdjustments
branch
from
September 8, 2025 20:06
2113cd0 to
ef32181
Compare
rsdmike
requested review from
graikhel-intel,
jaolanlo and
madhavilosetty-intel
September 8, 2025 20:06
rsdmike
force-pushed
the
proxyAdjustments
branch
from
September 8, 2025 20:25
ef32181 to
f49dd9d
Compare
graikhel-intel
approved these changes
Sep 8, 2025
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )