fix: AI code review

Author: nmgaston

src/app/devices/device-detail/device-detail.component.ts

@@ -186,7 +186,7 @@ export class DeviceDetailComponent implements OnInit, OnDestroy {
             catchError((err) => {
               const msg: string = this.translate.instant('general.errorAMTVersion.value')
               this.snackBar.open(msg, undefined, SnackbarDefaults.defaultError)
-              return throwError(err)
+              return throwError(() => err)
             })
           )
         })

src/app/devices/ider/ider.component.spec.ts

@@ -359,11 +359,12 @@ describe('IderComponent', () => {
     })
   })
 
-  it('should return true when IDER is false even if IDER is connected', (done) => {
+  it('should return null when IDER is connected even if AMT IDER feature is false', (done) => {
     const mockRedirectionStatus = { isKVMConnected: false, isSOLConnected: false, isIDERConnected: true }
     component.amtFeatures.set({ ...amtFeaturesResponse, IDER: false })
     component.handleRedirectionStatus(mockRedirectionStatus).subscribe((result) => {
-      expect(result).toBeTrue()
+      expect(result).toBeNull()
+      expect(snackBarSpy).toHaveBeenCalled()
       done()
     })
   })

src/app/devices/ider/ider.component.ts

@@ -262,7 +262,7 @@ export class IderComponent implements OnInit, OnDestroy {
     return this.devicesService.getRedirectionStatus(guid).pipe(
       catchError((err) => {
         this.isLoading.set(false)
-        const msg: string = this.translate.instant('kvm.errorRetrieve.value')
+        const msg: string = this.translate.instant('ider.errorRetrieve.value')
         this.displayError(msg)
         return throwError(() => err)
       })
@@ -271,8 +271,8 @@ export class IderComponent implements OnInit, OnDestroy {
 
   handleRedirectionStatus(redirectionStatus: RedirectionStatus): Observable<any> {
     this.redirectionStatus = redirectionStatus
-    if (this.amtFeatures()?.IDER && this.redirectionStatus.isIDERConnected) {
-      const msg: string = this.translate.instant('kvm.errorRetrieve.value')
+    if (this.redirectionStatus.isIDERConnected) {
+      const msg: string = this.translate.instant('ider.errorRetrieve.value')
       this.displayError(msg)
       return of(null)
     }
@@ -283,7 +283,7 @@ export class IderComponent implements OnInit, OnDestroy {
     return this.devicesService.getPowerState(guid).pipe(
       catchError((err) => {
         this.isLoading.set(false)
-        const msg: string = this.translate.instant('kvm.errorRetrieve.value')
+        const msg: string = this.translate.instant('ider.errorRetrieve.value')
         this.displayError(msg)
         return throwError(() => err)
       })

src/assets/i18n/ar.json

@@ -1632,6 +1632,10 @@
     "description": "تسمية الزر لإرفاق صورة قرص لـ IDER",
     "value": "إرفاق صورة القرص (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "خطأ في استرداد حالة إعادة التوجيه",
+    "value": "خطأ في استرداد حالة إعادة التوجيه"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "رسالة الحالة المعروضة أثناء استرداد ميزات AMT",
     "value": "جارٍ استرداد ميزات AMT..."

src/assets/i18n/de.json

@@ -1632,6 +1632,10 @@
     "description": "Schaltflächenbeschriftung zum Anhängen eines Disk-Images für IDER",
     "value": "Disk-Image (.iso) anhängen"
   },
+  "ider.errorRetrieve": {
+    "description": "Fehler beim Abrufen des Umleitungsstatus",
+    "value": "Fehler beim Abrufen des Weiterleitungsstatus"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "Statusmeldung beim Abrufen der AMT-Funktionen",
     "value": "AMT-Funktionen werden abgerufen..."

src/assets/i18n/en.json

@@ -1659,6 +1659,10 @@
     "description": "Button label to attach a disk image for IDER",
     "value": "Attach Disk Image (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "Error for retrieving redirection status",
+    "value": "Error retrieving redirection status"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "Status message shown while retrieving AMT features",
     "value": "Retrieving AMT features..."

src/assets/i18n/es.json

@@ -1632,6 +1632,10 @@
     "description": "Etiqueta del botón para adjuntar una imagen de disco para IDER.",
     "value": "Adjuntar imagen de disco (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "Error al recuperar el estado de redirección.",
+    "value": "Error al recuperar el estado de redirección."
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "Mensaje de estado mientras se recuperan las características de AMT",
     "value": "Recuperando características de AMT..."

src/assets/i18n/fi.json

@@ -1632,6 +1632,10 @@
     "description": "Painikkeen teksti levyn kuvan liittämiseksi IDER:ään",
     "value": "Liitä levykuva (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "Virhe uudelleenohjauksen tilan hakemisessa",
+    "value": "Virhe uudelleenohjauksen tilan hakemisessa"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "Tilailmoitus AMT-ominaisuuksia haettaessa",
     "value": "Haetaan AMT-ominaisuuksia..."

src/assets/i18n/fr.json

@@ -1632,6 +1632,10 @@
     "description": "Étiquette du bouton permettant de joindre une image disque pour IDER",
     "value": "Joindre une image disque (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "Erreur lors de la récupération du statut de redirection",
+    "value": "Erreur lors de la récupération du statut de redirection"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "Message d'état lors de la récupération des fonctionnalités AMT",
     "value": "Récupération des fonctionnalités AMT..."

src/assets/i18n/he.json

@@ -1632,6 +1632,10 @@
     "description": "תווית כפתור כדי לצרף תמונת דיסק עבור ider",
     "value": "צרף תמונת דיסק (.iso)"
   },
+  "ider.errorRetrieve": {
+    "description": "שגיאה לאחזור סטטוס הפניה מחדש",
+    "value": "שגיאה אחזור סטטוס הפניה מחדש"
+  },
   "ider.status.checkingAMTFeatures": {
     "description": "הודעת סטאטוס בעת אחזור תכונות AMT",
     "value": "מאחזר תכונות AMT..."