fix: AI review comments

Author: nmgaston

src/app/devices/general/general.component.spec.ts

@@ -7,11 +7,10 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { GeneralComponent } from './general.component'
 import { ActivatedRoute } from '@angular/router'
-import { of } from 'rxjs'
+import { of, Subject } from 'rxjs'
 import { DevicesService } from '../devices.service'
 import { provideTranslateService } from '@ngx-translate/core'
 import { By } from '@angular/platform-browser'
-import { Subject } from 'rxjs'
 
 describe('GeneralComponent', () => {
   let component: GeneralComponent
@@ -179,4 +178,25 @@ describe('GeneralComponent', () => {
     expect(component.isLoading()).toBeFalse()
     expect(component.isUpdatingFeatures()).toBeFalse()
   })
+
+  it('keeps feature loading state true until the last overlapping update completes', () => {
+    const firstResponse$ = new Subject<any>()
+    const secondResponse$ = new Subject<any>()
+    devicesServiceSpy.setAmtFeatures.and.returnValues(firstResponse$, secondResponse$)
+
+    component.setAmtFeatures()
+    component.setAmtFeatures()
+
+    expect(component.isUpdatingFeatures()).toBeTrue()
+
+    firstResponse$.next({ redirection: true, status: 'ok' })
+    firstResponse$.complete()
+
+    expect(component.isUpdatingFeatures()).toBeTrue()
+
+    secondResponse$.next({ redirection: true, status: 'ok' })
+    secondResponse$.complete()
+
+    expect(component.isUpdatingFeatures()).toBeFalse()
+  })
 })

src/app/devices/general/general.component.ts

@@ -96,6 +96,7 @@ export class GeneralComponent implements OnInit, OnDestroy {
   public isCloudMode: boolean = environment.cloud
 
   private readonly destroy$ = new Subject<void>()
+  private pendingFeatureUpdates = 0
 
   ngOnInit(): void {
     forkJoin({
@@ -181,6 +182,7 @@ export class GeneralComponent implements OnInit, OnDestroy {
   }
 
   setAmtFeatures(): void {
+    this.pendingFeatureUpdates += 1
     this.isUpdatingFeatures.set(true)
     this.devicesService
       .setAmtFeatures(this.deviceId(), {
@@ -189,7 +191,8 @@ export class GeneralComponent implements OnInit, OnDestroy {
       } as AMTFeaturesRequest)
       .pipe(
         finalize(() => {
-          this.isUpdatingFeatures.set(false)
+          this.pendingFeatureUpdates = Math.max(0, this.pendingFeatureUpdates - 1)
+          this.isUpdatingFeatures.set(this.pendingFeatureUpdates > 0)
         })
       )
       .subscribe({