fix: address review comments

Author: DevipriyaS17

src/app/devices/device-toolbar/device-toolbar.component.html

@@ -55,7 +55,7 @@
       mat-icon-button
       type="button"
       [matTooltip]="powerState() | translate"
-      aria-label="Refresh power status"
+      [attr.aria-label]="'deviceToolbar.power.refreshAriaLabel.value' | translate"
       style="padding: 0 18px 0 12px"
       [style.color]="
         powerState() === 'deviceToolbar.power.on.value'

src/app/devices/device-toolbar/device-toolbar.component.ts

@@ -233,35 +233,26 @@ export class DeviceToolbarComponent implements OnInit {
 
   private loadPowerState(): void {
     // Use cached to dedupe simultaneous requests (KVM deep-link + toolbar both loading).
-    this.isLoading().set(true)
-    this.devicesService
-      .getPowerStateCached(this.deviceId())
-      .pipe(
-        catchError(() => {
-          // Network/backend failure; silently skip update and let UI show previous state.
-          return EMPTY
-        }),
-        finalize(() => {
-          this.isLoading().set(false)
-        }),
-        takeUntilDestroyed(this.destroyRef)
-      )
-      .subscribe((powerState) => {
-        this.setPowerStateLabel(powerState.powerstate)
-      })
+    this.fetchPowerState(this.devicesService.getPowerStateCached(this.deviceId()))
   }
 
   refreshPowerState(): void {
+    // Bypass the cache so manual refresh always fetches the latest state from the device.
+    this.fetchPowerState(this.devicesService.getPowerState(this.deviceId()), () => {
+      const msg: string = this.translate.instant('kvm.errorRetrievePower.value')
+      this.snackBar.open(msg, undefined, SnackbarDefaults.defaultError)
+    })
+  }
+
+  private fetchPowerState(source: Observable<any>, onError?: () => void): void {
     this.isLoading().set(true)
-    // Bypass the cache so manual refresh always fetches the latest state from the
-    // device rather than returning a previously cached value.
-    this.devicesService
-      .getPowerState(this.deviceId())
+    source
       .pipe(
         catchError((err) => {
-          console.error(err)
-          const msg: string = this.translate.instant('kvm.errorRetrievePower.value')
-          this.snackBar.open(msg, undefined, SnackbarDefaults.defaultError)
+          if (onError) {
+            console.error(err)
+            onError()
+          }
           return EMPTY
         }),
         finalize(() => {
@@ -475,6 +466,7 @@ export class DeviceToolbarComponent implements OnInit {
             const msg: string = this.translate.instant('devices.powerActionSent.value')
             console.log('Power action sent successfully:', data)
             this.snackBar.open(msg, undefined, SnackbarDefaults.defaultSuccess)
+            this.refreshPowerState()
           } else {
             console.log('Power action failed:', data)
             const msg: string = this.translate.instant('devices.failPowerAction.value')

src/assets/i18n/en.json

@@ -1253,6 +1253,10 @@
     "description": "Power tooltip for Off",
     "value": "Power: Off"
   },
+  "deviceToolbar.power.refreshAriaLabel": {
+    "description": "Aria label for the refresh power status button",
+    "value": "Refresh power status"
+  },
   "deviceUserConsent.description": {
     "description": "Description for user consent for devices",
     "value": "A user consent code generated by Intel AMT is required to access the system."