Skip to content

feat: enable hotkey drop down for KVM#2772

Merged
rsdmike merged 2 commits into
mainfrom
kvmEnhancements
Jul 29, 2025
Merged

feat: enable hotkey drop down for KVM#2772
rsdmike merged 2 commits into
mainfrom
kvmEnhancements

Conversation

@rsdmike

@rsdmike rsdmike commented Jul 29, 2025

Copy link
Copy Markdown
Member

#1391

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Copilot AI review requested due to automatic review settings July 29, 2025 20:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables hotkey dropdown functionality for KVM by converting EventEmitter properties to signals and adding a hotkey selection interface. The changes modernize the component communication pattern while adding new KVM hotkey capabilities.

  • Converts EventEmitter outputs to signals in both SOL and KVM components
  • Adds hotkey dropdown with predefined Windows and system hotkeys for KVM
  • Updates the UI toolkit dependency to version 10.1.0

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/app/devices/sol/sol.component.ts Converts deviceConnection from EventEmitter to signal
src/app/devices/sol/sol.component.html Updates template to use signal syntax for deviceConnection
src/app/devices/kvm/kvm.component.ts Converts multiple EventEmitters to signals and adds hotkey functionality
src/app/devices/kvm/kvm.component.html Adds hotkey dropdown UI and updates template to use signal syntax
package.json Updates UI toolkit dependency to version 10.1.0
Comments suppressed due to low confidence (1)

src/app/devices/kvm/kvm.component.ts:87

  • The type 'any' is too generic for hotKeySignal. Consider using a more specific type like 'string | null' since the hotkey values are strings.
  public hotKeySignal = signal<any>(null)

Comment thread src/app/devices/kvm/kvm.component.html Outdated
@rsdmike
rsdmike force-pushed the kvmEnhancements branch 2 times, most recently from d6c65cf to 9d7ac94 Compare July 29, 2025 20:53
@rsdmike
rsdmike enabled auto-merge (rebase) July 29, 2025 20:53
@rsdmike
rsdmike force-pushed the kvmEnhancements branch 3 times, most recently from 110c316 to 4a4ecbd Compare July 29, 2025 21:15
@rsdmike
rsdmike merged commit 6a12c7f into main Jul 29, 2025
8 checks passed
@rsdmike
rsdmike deleted the kvmEnhancements branch July 29, 2025 21:53
@RosieAMT

Copy link
Copy Markdown

🎉 This PR is included in version 3.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rsdmike rsdmike linked an issue Oct 24, 2025 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'Ctrl+Alt+Delete' Button to KVM Page

4 participants