feat: enable hotkey drop down for KVM#2772
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables hotkey dropdown functionality for KVM by converting EventEmitter properties to signals and adding a hotkey selection interface. The changes modernize the component communication pattern while adding new KVM hotkey capabilities.
- Converts EventEmitter outputs to signals in both SOL and KVM components
- Adds hotkey dropdown with predefined Windows and system hotkeys for KVM
- Updates the UI toolkit dependency to version 10.1.0
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/app/devices/sol/sol.component.ts | Converts deviceConnection from EventEmitter to signal |
| src/app/devices/sol/sol.component.html | Updates template to use signal syntax for deviceConnection |
| src/app/devices/kvm/kvm.component.ts | Converts multiple EventEmitters to signals and adds hotkey functionality |
| src/app/devices/kvm/kvm.component.html | Adds hotkey dropdown UI and updates template to use signal syntax |
| package.json | Updates UI toolkit dependency to version 10.1.0 |
Comments suppressed due to low confidence (1)
src/app/devices/kvm/kvm.component.ts:87
- The type 'any' is too generic for hotKeySignal. Consider using a more specific type like 'string | null' since the hotkey values are strings.
public hotKeySignal = signal<any>(null)
rsdmike
force-pushed
the
kvmEnhancements
branch
2 times, most recently
from
July 29, 2025 20:53
d6c65cf to
9d7ac94
Compare
rsdmike
enabled auto-merge (rebase)
July 29, 2025 20:53
rsdmike
force-pushed
the
kvmEnhancements
branch
3 times, most recently
from
July 29, 2025 21:15
110c316 to
4a4ecbd
Compare
graikhel-intel
approved these changes
Jul 29, 2025
|
🎉 This PR is included in version 3.40.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1391
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )