feat: avoid reloading AMT Summary when updating AMT Features#3427
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines GeneralComponent loading-state management so AMT feature updates no longer reuse the summary-loading signal, enabling more targeted UI feedback during AMT feature updates.
Changes:
- Introduces a dedicated
isUpdatingFeaturessignal to track AMT feature-update in-flight state independently ofisLoading. - Updates the AMT Enabled Features UI to show an indeterminate
mat-progress-baronly while features are being updated. - Adds unit tests validating that feature-update loading does not affect the summary-loading state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/devices/general/general.component.ts | Adds isUpdatingFeatures and switches setAmtFeatures() to toggle it instead of isLoading. |
| src/app/devices/general/general.component.html | Displays a progress bar inside the AMT Enabled Features card when isUpdatingFeatures() is true. |
| src/app/devices/general/general.component.spec.ts | Adds tests for independent loading states during feature updates. |
4 tasks
nmgaston
force-pushed
the
noloadSummaryOnFeatureChange
branch
from
July 10, 2026 04:15
8db13ae to
30ba937
Compare
nmgaston
marked this pull request as ready for review
July 10, 2026 04:23
madhavilosetty-intel
enabled auto-merge (squash)
July 20, 2026 21:06
madhavilosetty-intel
approved these changes
Jul 20, 2026
RosieAMT
pushed a commit
that referenced
this pull request
Jul 20, 2026
# [3.61.0](v3.60.1...v3.61.0) (2026-07-20) ### Features * avoid reloading AMT Summary when updating AMT Features ([#3427](#3427)) ([2703ec1](2703ec1))
|
🎉 This PR is included in version 3.61.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the loading state management in the
GeneralComponentto provide more granular feedback when updating AMT features. Instead of using a single loading state for all operations, a dedicatedisUpdatingFeaturessignal is introduced. This allows the UI to display a progress bar specifically when AMT features are being updated, without interfering with other loading indicators. Unit tests have been added to verify this improved behavior.UI and State Management Improvements:
isUpdatingFeaturessignal toGeneralComponentto track the loading state specifically for AMT feature updates, decoupling it from the general loading state (isLoading). (src/app/devices/general/general.component.ts)mat-progress-baronly whenisUpdatingFeatures()is true, giving users more precise feedback during feature updates. (src/app/devices/general/general.component.html)Testing Enhancements:
isUpdatingFeatures) is managed independently from the summary loading state (isLoading). (src/app/devices/general/general.component.spec.ts)setAmtFeaturesmethod and useSubjectfor simulating asynchronous responses. (src/app/devices/general/general.component.spec.ts)PR Checklist