refactor: rename deviceInfo lastUpdated to lastSynced, add firstDiscovered#3443
Merged
Conversation
…vered Aligns DeviceInfo model with console discovery-timestamp changes. Type-only field; not rendered, so no runtime dependency on the API change. Related to device-management-toolkit/rpc-go#1394
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared DeviceInfo TypeScript model to match the Console-side discovery timestamp terminology, keeping the change limited to the timestamp pair rename/addition as described in the PR.
Changes:
- Renamed
DeviceInfo.lastUpdatedtoDeviceInfo.lastSynced - Added
DeviceInfo.firstDiscoveredtimestamp field
sinchubhat
marked this pull request as ready for review
July 16, 2026 04:27
sinchubhat
force-pushed
the
issue1394-rpc-go
branch
from
July 16, 2026 06:43
aa71c2a to
f5ea597
Compare
madhavilosetty-intel
approved these changes
Jul 16, 2026
sudhir-intc
approved these changes
Jul 17, 2026
|
🎉 This PR is included in version 3.60.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns DeviceInfo model with console discovery-timestamp changes. Type-only field; not rendered, so no runtime dependency on the API change.
Related to device-management-toolkit/rpc-go#1394
Note:
Kept the sample-web-ui change scoped to the lastUpdated->lastSynced rename (+ firstDiscovered as the timestamp pair). The remaining discovery fields (osName, SKU type, control mode filters, certHashes, etc.) are owned by the Discovery Dashboard work - console#1093 and sample-web-ui#1265 - and should be added there alongside the columns/filters that render them, not speculatively here.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )