Skip to content

Commit d05c9cd

Browse files
finalerock44finalerock44
committed
Remove additional-app-files / additional-app-binary-ids inputs
The additionalAppBinaryIds/additionalAppFiles feature was removed server-side (the API rejects requests using it with a 400) and the v5 CLI no longer accepts the flags, so these inputs were a silent no-op. Drop them from action.yml and stop forwarding them to the CLI. Rebuilt dist; all tests pass.
1 parent 6397676 commit d05c9cd

4 files changed

Lines changed: 7 additions & 33 deletions

File tree

‎action.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ inputs:
1414
app-binary-id:
1515
description: 'The ID of the app binary previously uploaded to devicecloud.dev'
1616
required: false
17-
additional-app-files:
18-
description: 'Additional app binary(s) to install before execution'
19-
required: false
20-
additional-app-binary-ids:
21-
description: 'The ID of the additional app binary(s) previously uploaded to devicecloud.dev to install before execution'
22-
required: false
2317
android-api-level:
2418
description: '[Android only] Android API level to run your flow against <options: 29|30|31|32|33|34|35|36>'
2519
required: false

‎dist/index.js‎

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2216,7 +2216,7 @@ const Context = __importStar(__nccwpck_require__(8663));
22162216
const Utils = __importStar(__nccwpck_require__(1365));
22172217
// octokit + plugins
22182218
const core_1 = __nccwpck_require__(6895);
2219-
const plugin_rest_endpoint_methods_1 = __nccwpck_require__(9289);
2219+
const plugin_rest_endpoint_methods_1 = __nccwpck_require__(6495);
22202220
const plugin_paginate_rest_1 = __nccwpck_require__(6212);
22212221
exports.context = new Context.Context();
22222222
const baseUrl = Utils.getApiBaseUrl();
@@ -40647,7 +40647,7 @@ const getLatestDcdVersion = (...args_1) => __awaiter(void 0, [...args_1], void 0
4064740647
const run = () => __awaiter(void 0, void 0, void 0, function* () {
4064840648
var _a;
4064940649
try {
40650-
const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, runnerType, debug, moropoV1ApiKey, useBeta, maestroChromeOnboarding, androidNoSnapshot, disableAnimations, githubContext, } = yield (0, params_1.getParameters)();
40650+
const { androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, runnerType, debug, moropoV1ApiKey, useBeta, maestroChromeOnboarding, androidNoSnapshot, disableAnimations, githubContext, } = yield (0, params_1.getParameters)();
4065140651
const REMOVED_MAESTRO_VERSIONS = ['1.39.2', '1.39.7', '2.0.3'];
4065240652
if (maestroVersion && REMOVED_MAESTRO_VERSIONS.includes(maestroVersion)) {
4065340653
(0, core_1.setFailed)(`Maestro version ${maestroVersion} is no longer supported. ` +
@@ -40656,8 +40656,6 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
4065640656
}
4065740657
const dcdVersionString = yield getLatestDcdVersion(useBeta);
4065840658
const params = {
40659-
'additional-app-binary-ids': additionalAppBinaryIds,
40660-
'additional-app-files': additionalAppFiles,
4066140659
'android-api-level': androidApiLevel,
4066240660
'android-device': androidDevice,
4066340661
'api-key': apiKey,
@@ -40928,8 +40926,6 @@ function getParameters() {
4092840926
const iosDevice = parseIOSDevice(core.getInput('ios-device', { required: false }));
4092940927
const excludeFlows = core.getInput('exclude-flows', { required: false });
4093040928
const googlePlay = core.getInput('google-play', { required: false }) === 'true';
40931-
const additionalAppBinaryIds = parseTags(core.getInput('additional-app-binary-ids', { required: false }));
40932-
const additionalAppFiles = parseTags(core.getInput('additional-app-files', { required: false }));
4093340929
const deviceLocale = core.getInput('device-locale', { required: false });
4093440930
const downloadArtifacts = parseDownloadArtifacts(core.getInput('download-artifacts', { required: false }));
4093540931
const maestroVersion = core.getInput('maestro-version', { required: false });
@@ -40976,8 +40972,6 @@ function getParameters() {
4097640972
iosDevice,
4097740973
excludeFlows,
4097840974
googlePlay,
40979-
additionalAppBinaryIds,
40980-
additionalAppFiles,
4098140975
deviceLocale,
4098240976
downloadArtifacts,
4098340977
maestroVersion,
@@ -43159,7 +43153,7 @@ paginateRest.VERSION = VERSION;
4315943153

4316043154
/***/ }),
4316143155

43162-
/***/ 9289:
43156+
/***/ 6495:
4316343157
/***/ ((__unused_webpack___webpack_module__, __webpack_exports__, __nccwpck_require__) => {
4316443158

4316543159
"use strict";
@@ -43172,12 +43166,12 @@ __nccwpck_require__.d(__webpack_exports__, {
4317243166
restEndpointMethods: () => (/* binding */ restEndpointMethods)
4317343167
});
4317443168

43175-
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoint-methods@17.0.0_@octokit+core@7.0.6/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/version.js
43169+
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoi_88f1cfdccbcd12f9bd89a662a3d08bce/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/version.js
4317643170
const VERSION = "17.0.0";
4317743171

4317843172
//# sourceMappingURL=version.js.map
4317943173

43180-
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoint-methods@17.0.0_@octokit+core@7.0.6/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/generated/endpoints.js
43174+
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoi_88f1cfdccbcd12f9bd89a662a3d08bce/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/generated/endpoints.js
4318143175
const Endpoints = {
4318243176
actions: {
4318343177
addCustomLabelsToSelfHostedRunnerForOrg: [
@@ -45471,7 +45465,7 @@ var endpoints_default = Endpoints;
4547145465

4547245466
//# sourceMappingURL=endpoints.js.map
4547345467

45474-
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoint-methods@17.0.0_@octokit+core@7.0.6/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/endpoints-to-methods.js
45468+
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoi_88f1cfdccbcd12f9bd89a662a3d08bce/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/endpoints-to-methods.js
4547545469

4547645470
const endpointMethodsMap = /* @__PURE__ */ new Map();
4547745471
for (const [scope, endpoints] of Object.entries(endpoints_default)) {
@@ -45597,7 +45591,7 @@ function decorate(octokit, scope, methodName, defaults, decorations) {
4559745591

4559845592
//# sourceMappingURL=endpoints-to-methods.js.map
4559945593

45600-
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoint-methods@17.0.0_@octokit+core@7.0.6/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/index.js
45594+
;// CONCATENATED MODULE: ./node_modules/.pnpm/@octokit+plugin-rest-endpoi_88f1cfdccbcd12f9bd89a662a3d08bce/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/index.js
4560145595

4560245596

4560345597
function restEndpointMethods(octokit) {

‎src/index.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@ const getLatestDcdVersion = async (useBeta: boolean = false): Promise<string> =>
122122
const run = async (): Promise<void> => {
123123
try {
124124
const {
125-
additionalAppBinaryIds,
126-
additionalAppFiles,
127125
androidApiLevel,
128126
androidDevice,
129127
apiKey,
@@ -171,8 +169,6 @@ const run = async (): Promise<void> => {
171169
const dcdVersionString = await getLatestDcdVersion(useBeta);
172170

173171
const params: Record<string, any> = {
174-
'additional-app-binary-ids': additionalAppBinaryIds,
175-
'additional-app-files': additionalAppFiles,
176172
'android-api-level': androidApiLevel,
177173
'android-device': androidDevice,
178174
'api-key': apiKey,

‎src/methods/params.ts‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ export type Params = {
1818
googlePlay: boolean;
1919
iosDevice: string | null;
2020
name?: string;
21-
additionalAppBinaryIds: string[] | null;
22-
additionalAppFiles: string[] | null;
2321
deviceLocale?: string;
2422
downloadArtifacts?: 'ALL' | 'FAILED';
2523
maestroVersion?: string;
@@ -175,12 +173,6 @@ export async function getParameters(): Promise<Params> {
175173
const googlePlay =
176174
core.getInput('google-play', { required: false }) === 'true';
177175

178-
const additionalAppBinaryIds = parseTags(
179-
core.getInput('additional-app-binary-ids', { required: false })
180-
);
181-
const additionalAppFiles = parseTags(
182-
core.getInput('additional-app-files', { required: false })
183-
);
184176
const deviceLocale = core.getInput('device-locale', { required: false });
185177
const downloadArtifacts = parseDownloadArtifacts(
186178
core.getInput('download-artifacts', { required: false })
@@ -247,8 +239,6 @@ export async function getParameters(): Promise<Params> {
247239
iosDevice,
248240
excludeFlows,
249241
googlePlay,
250-
additionalAppBinaryIds,
251-
additionalAppFiles,
252242
deviceLocale,
253243
downloadArtifacts,
254244
maestroVersion,

0 commit comments

Comments
 (0)