lopper: assists: xlnx_overlay_pl_dt: exclude address-map property from overlay#748
Merged
Merged
Conversation
Collaborator
|
It's ok to keep the check, it just won't be used .. but if something breaks it is a good secondary check. I have no issues with the change now. |
Collaborator
|
Any other reviews needed for this ? |
kedareswararao
approved these changes
May 4, 2026
Collaborator
|
I had to update master to fix some issues with the previous release, can you rebase and resend this pull request ? |
…m overlay address-map is an SDT-specific property that is not consumed by the Linux kernel at runtime. Automatically exclude it from the generated pl.dtsi and clean up any empty overlay fragments left behind. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
arthokal
force-pushed
the
addr_map_prop_exclude
branch
from
19bb6bd to
43cce44
Compare
Contributor
Author
|
@zeddii ,
Fixed. Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current status:
With latest changes in master branch,
When overlay_of() is called, fragments are now automatically generated for any base tree properties that reference overlay nodes. This ensures cross-tree references remain valid. Hence address-map properties are generated in the overlay which provides the complete address-map including both PS and PL device entries.
Fix:
address-map is an SDT-specific property that is not consumed by the Linux kernel at runtime. Automatically exclude it from the generated pl.dtsi and clean up any empty overlay fragments left behind.
Closed PR #746 as it was based on old upstream master.
@Zeddi,
I confirm that PL overlay use cases pass on master and there are no warnings. Please review.
Should I still keep cleaning up of empty fragments through regex? You were mentioning this last time:
CC: @onkarharsh , @kedareswararao , @sivadur