baremetalconfig_xlnx: fix clocks single-cell offset; optional prop first int#756
Merged
Merged
Conversation
…rst int
baremetalconfig_xlnx: fix clock cell indexing and optional CMake ints
Clocks:
- With no clock-names, use offset 0 when clocks has a single phandle cell
(avoids out-of-range access and spurious warnings on IPs like MDM).
- On out-of-range offset, return value[0]; warn only when multiple cells exist.
Fixes incorrect use of value[1] when only one cell is present.
Optional driver metadata (DRIVER_OPTPROP_*):
- Take node[prop].value[0]; if it is a string, parse the first comma-separated
token as int (e.g. "0 , 1 , 0" -> first value only).
Signed-off-by: Harish Babu Pamarthi <HarishBabu.Pamarthi@amd.com>
Collaborator
|
any additional reviews needed for this one ? |
kedareswararao
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baremetalconfig_xlnx: fix clock cell indexing and optional CMake ints
Clocks: