Skip to content

Commit 8817277

Browse files
committed
Fix missing .pdb files for singular net472 TFM projects.
1 parent 5ecf1be commit 8817277

33 files changed

Lines changed: 20 additions & 20 deletions

.github/copilot-instructions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ The main build dependency is a current .NET SDK. Visual Studio is recommended fo
3030
- Run `build.cmd` or `build.ps1` from the repository root to perform a full build.
3131
- Prefer the existing VS Code tasks and build entry points over ad-hoc commands when validating changes.
3232
- Common validation tasks include `Build`, `Test`, `Analyze`, `FormattingCheck`, and `ValidateRequirements`.
33+
- Only build from within Visual Studio; do not use `dotnet build` for validation/builds.
3334

3435
## Repository Orientation
3536

Directory.Build.props

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -42,25 +42,6 @@
4242
<Optimize>true</Optimize>
4343
</PropertyGroup>
4444

45-
<!-- ARM64 preference for .NET Framework -->
46-
<PropertyGroup Condition="'$(TargetFramework)' == 'net472'">
47-
<PreferNativeArm64>true</PreferNativeArm64>
48-
<DebugType>full</DebugType>
49-
</PropertyGroup>
50-
51-
<!-- Debugging symbol setup for .NET Framework -->
52-
<PropertyGroup Condition="'$(TargetFramework)' == 'net472' And '$(Configuration)' == 'Release'">
53-
<DebugType>pdbonly</DebugType>
54-
</PropertyGroup>
55-
<PropertyGroup Condition="'$(TargetFramework)' == 'net472' And '$(Configuration)' == 'Debug'">
56-
<DebugType>full</DebugType>
57-
</PropertyGroup>
58-
59-
<!-- Debugging symbol setup for .NET Core -->
60-
<PropertyGroup Condition="'$(TargetFramework)' != 'net472'">
61-
<DebugType>embedded</DebugType>
62-
</PropertyGroup>
63-
6445
<!-- Banned API analyzer -->
6546
<ItemGroup>
6647
<PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4">

Directory.Build.targets

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,22 @@
11
<Project>
2+
<!-- ARM64 preference for .NET Framework -->
3+
<PropertyGroup Condition="'$(TargetFramework)' == 'net472'">
4+
<PreferNativeArm64>true</PreferNativeArm64>
5+
</PropertyGroup>
6+
7+
<!-- Debugging symbol setup for .NET Framework -->
8+
<PropertyGroup Condition="'$(TargetFramework)' == 'net472' And '$(Configuration)' == 'Release'">
9+
<DebugType>pdbonly</DebugType>
10+
</PropertyGroup>
11+
<PropertyGroup Condition="'$(TargetFramework)' == 'net472' And '$(Configuration)' == 'Debug'">
12+
<DebugType>full</DebugType>
13+
</PropertyGroup>
14+
15+
<!-- Debugging symbol setup for .NET Core -->
16+
<PropertyGroup Condition="'$(TargetFramework)' != 'net472'">
17+
<DebugType>embedded</DebugType>
18+
</PropertyGroup>
19+
220
<!-- Silence incompatibility warnings since we're not targeting Windows directly -->
321
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
422
<NoWarn>$(NoWarn);CA1416</NoWarn>

src/PSADT/PSADT.UserInterface.Interfaces.TestHarness/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private static async Task Main()
4747
throw new InvalidDataException($"Error parsing strings.psd1 file.");
4848
}
4949

50-
// Read out the hashtable
50+
// Read out the hashtable.
5151
Hashtable stringTable = (Hashtable)stringsAst.Find(node =>
5252
node is HashtableAst innerHt &&
5353
innerHt.Parent is CommandExpressionAst ce1 &&
1 KB
Binary file not shown.
0 Bytes
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)