Simplify the username obtainment within ProcessUtilities.GetRunningProcesses().

Author: mjr4077au

src/PSADT/PSADT/ProcessManagement/ProcessUtilities.cs

@@ -9,7 +9,6 @@
 using System.Security.Principal;
 using System.ServiceProcess;
 using Microsoft.Win32.SafeHandles;
-using PSADT.AccountManagement;
 using PSADT.Extensions;
 using PSADT.FileSystem;
 using PSADT.LibraryInterfaces;
@@ -182,8 +181,8 @@ static string[] GetProcessArgv(Process process, Dictionary<Process, string[]> pr
                     NTAccount? username = null;
                     if (!process.HasExited)
                     {
-                        // Leverage SeDebugPrivilege if we have it for complete accuracy.
-                        if (PrivilegeManager.HasPrivilege(SE_PRIVILEGE.SeDebugPrivilege))
+                        // Users can only get the username for their own processes, whereas admins can get anyone's.
+                        try
                         {
                             // We're caching the process, so don't dispose of its SafeHande as .NET caches it also...
                             _ = AdvApi32.OpenProcessToken(process.SafeHandle, TOKEN_ACCESS_MASK.TOKEN_QUERY, out SafeFileHandle hToken);
@@ -192,23 +191,9 @@ static string[] GetProcessArgv(Process process, Dictionary<Process, string[]> pr
                                 username = TokenManager.GetTokenSid(hToken).Translate(typeof(NTAccount)) as NTAccount;
                             }
                         }
-
-                        // If we couldn't get it that way, test for session Id equality.
-                        if (username is null)
+                        catch (Exception ex) when (ex.Message is not null)
                         {
-                            // This needs to be in a try/catch as accessing SessionId can throw E_ACCESSDENIED exceptions.
-                            try
-                            {
-                                if (process.SessionId == AccountUtilities.CallerSessionId)
-                                {
-                                    // The process is in our session, so assume it's ours.
-                                    username = AccountUtilities.CallerUsername;
-                                }
-                            }
-                            catch (Exception ex) when (ex.Message is not null)
-                            {
-                                username = null;
-                            }
+                            username = null;
                         }
                     }