Rename ADTRegSvr32 -PerUser to -AsUser, remove redundant user/context guards

Signed-off-by: Tom Plant <tom.plant@devicie.com>

Author: pl4nty

src/PSAppDeployToolkit/Public/Invoke-ADTRegSvr32.ps1

@@ -19,7 +19,7 @@ function Invoke-ADTRegSvr32
     .PARAMETER Action
         Specify whether to register or unregister the DLL.
 
-    .PARAMETER PerUser
+    .PARAMETER AsUser
         Specifies that the DLL should be registered for the current user only by calling its DllInstall entry point with the 'user' argument (regsvr32.exe /n /i:user). If this function is running under the SYSTEM account, regsvr32.exe is executed in the context of the currently logged on user. Note that the DLL must support per-user registration via a DllInstall export for this to work.
 
     .INPUTS
@@ -43,7 +43,7 @@ function Invoke-ADTRegSvr32
         Unregisters the specified DLL file.
 
     .EXAMPLE
-        Invoke-ADTRegSvr32 -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -Action 'Register' -PerUser
+        Invoke-ADTRegSvr32 -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -Action 'Register' -AsUser
 
         Registers the specified DLL file for the currently logged on user only.
 
@@ -83,7 +83,7 @@ function Invoke-ADTRegSvr32
         [System.String]$Action,
 
         [Parameter(Mandatory = $false)]
-        [System.Management.Automation.SwitchParameter]$PerUser
+        [System.Management.Automation.SwitchParameter]$AsUser
     )
 
     begin
@@ -94,12 +94,12 @@ function Invoke-ADTRegSvr32
         {
             Register
             {
-                "/s$(if ($PerUser) { ' /n /i:user' }) `"$FilePath`""
+                "/s$(if ($AsUser) { ' /n /i:user' }) `"$FilePath`""
                 break
             }
             Unregister
             {
-                "/s /u$(if ($PerUser) { ' /n /i:user' }) `"$FilePath`""
+                "/s /u$(if ($AsUser) { ' /n /i:user' }) `"$FilePath`""
                 break
             }
         }
@@ -166,19 +166,8 @@ function Invoke-ADTRegSvr32
 
                 # Register the DLL file and measure the success. Per-user registration writes to the
                 # user's HKCU hive, so when running as SYSTEM, execute as the logged on user instead.
-                if ($PerUser -and [PSADT.AccountManagement.AccountUtilities]::CallerSid.IsWellKnown([System.Security.Principal.WellKnownSidType]::LocalSystemSid))
+                if ($AsUser)
                 {
-                    if (!(Get-ADTClientServerUser))
-                    {
-                        $naerParams = @{
-                            Exception = [System.InvalidOperationException]::new("The DLL file [$FilePath] cannot be $($Action.ToLowerInvariant() + 'ed') per-user as there is no logged on user to process the request against.")
-                            Category = [System.Management.Automation.ErrorCategory]::InvalidOperation
-                            ErrorId = 'NoActiveUserError'
-                            TargetObject = $FilePath
-                            RecommendedAction = "Please ensure a user is logged onto the system and try again."
-                        }
-                        throw (New-ADTErrorRecord @naerParams)
-                    }
                     Start-ADTProcessAsUser -FilePath $RegSvr32Path -ArgumentList $ActionParameters -CreateNoWindow -SuccessExitCodes 0
                 }
                 else

src/PSAppDeployToolkit/Public/Register-ADTDll.ps1

@@ -16,7 +16,7 @@ function Register-ADTDll
     .PARAMETER FilePath
         Path to the DLL file.
 
-    .PARAMETER PerUser
+    .PARAMETER AsUser
         Specifies that the DLL should be registered for the current user only by calling its DllInstall entry point with the 'user' argument (regsvr32.exe /n /i:user). If this function is running under the SYSTEM account, regsvr32.exe is executed in the context of the currently logged on user. Note that the DLL must support per-user registration via a DllInstall export for this to work.
 
     .INPUTS
@@ -35,7 +35,7 @@ function Register-ADTDll
         Registers the specified DLL file.
 
     .EXAMPLE
-        Register-ADTDll -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -PerUser
+        Register-ADTDll -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -AsUser
 
         Registers the specified DLL file for the currently logged on user only.
 
@@ -70,7 +70,7 @@ function Register-ADTDll
         [System.String]$FilePath,
 
         [Parameter(Mandatory = $false)]
-        [System.Management.Automation.SwitchParameter]$PerUser
+        [System.Management.Automation.SwitchParameter]$AsUser
     )
 
     begin

src/PSAppDeployToolkit/Public/Unregister-ADTDll.ps1

@@ -16,7 +16,7 @@ function Unregister-ADTDll
     .PARAMETER FilePath
         Path to the DLL file.
 
-    .PARAMETER PerUser
+    .PARAMETER AsUser
         Specifies that the DLL should be unregistered for the current user only by calling its DllInstall entry point with the 'user' argument (regsvr32.exe /u /n /i:user). If this function is running under the SYSTEM account, regsvr32.exe is executed in the context of the currently logged on user. Note that the DLL must support per-user registration via a DllInstall export for this to work.
 
     .INPUTS
@@ -35,7 +35,7 @@ function Unregister-ADTDll
         Unregisters the specified DLL file.
 
     .EXAMPLE
-        Unregister-ADTDll -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -PerUser
+        Unregister-ADTDll -FilePath "C:\Test\DcTLSFileToDMSComp.dll" -AsUser
 
         Unregisters the specified DLL file for the currently logged on user only.
 
@@ -70,7 +70,7 @@ function Unregister-ADTDll
         [System.String]$FilePath,
 
         [Parameter(Mandatory = $false)]
-        [System.Management.Automation.SwitchParameter]$PerUser
+        [System.Management.Automation.SwitchParameter]$AsUser
     )
 
     begin