Drop all params method parameters from public methods.

This doesn't allow for stricter setups, such as defaulting such parameters to null, then ensuring a non-null parameter is not empty either.

Author: mjr4077au

src/PSADT/PSADT/ProcessManagement/RunningProcessInfo.cs

@@ -24,7 +24,7 @@ public sealed record RunningProcessInfo
         /// <remarks>This method identifies running processes by comparing their names and command-line arguments against the provided process definitions. If a process definition includes a filter, only processes that satisfy the filter are included in the result. Processes that cannot be accessed due to insufficient privileges are skipped.</remarks>
         /// <param name="processDefinitions">An array of <see cref="ProcessDefinition"/> objects that define the processes to search for. Each definition specifies the name, optional description, and an optional filter to match processes.</param>
         /// <returns>A read-only list of <see cref="RunningProcessInfo"/> objects representing the processes that match the given definitions. The list is ordered by the description of the running processes.</returns>
-        public static IReadOnlyList<RunningProcessInfo> Get(params IReadOnlyList<ProcessDefinition> processDefinitions)
+        public static IReadOnlyList<RunningProcessInfo> Get(IReadOnlyList<ProcessDefinition> processDefinitions)
         {
             // Set up some caches for performance.
             if (!(processDefinitions?.Count > 0))

src/PSADT/PSADT/Utilities/ShellUtilities.cs

@@ -32,7 +32,7 @@ internal static void RefreshDesktop()
             _ = NativeMethods.SendNotifyMessage(HWND.HWND_BROADCAST, WINDOW_MESSAGE.WM_SETTINGCHANGE, null, "TraySettings");
 
             // Terminate the StartMenuExperienceHost to refresh the start menu. Windows restarts this process instantly.
-            foreach (RunningProcessInfo runningProcessInfo in RunningProcessInfo.Get(new ProcessDefinition("StartMenuExperienceHost")))
+            foreach (RunningProcessInfo runningProcessInfo in RunningProcessInfo.Get([new("StartMenuExperienceHost")]))
             {
                 using Process process = runningProcessInfo.Process;
                 process.Kill();

src/PSADT/PSADT/WindowsInstaller/MsiSummaryInfo.cs

@@ -24,7 +24,7 @@ public sealed record MsiSummaryInfo
         /// information. If null, no transforms are applied.</param>
         /// <returns>An instance of MsiSummaryInfo containing the summary information extracted from the specified database, with
         /// any transforms applied.</returns>
-        public static MsiSummaryInfo Get(string szDatabasePath, params IReadOnlyList<string>? szTransformFiles)
+        public static MsiSummaryInfo Get(string szDatabasePath, IReadOnlyList<string>? szTransformFiles = null)
         {
             // Get the summary information from the given database, with any specified transform files applied.
             using MsiCloseHandleSafeHandle hSummaryInfo = MsiUtilities.GetSummaryInformation(szDatabasePath, szTransformFiles);

src/PSADT/PSADT/WindowsInstaller/MsiUtilities.cs

@@ -61,7 +61,7 @@ public static class MsiUtilities
         /// <returns>A read-only dictionary containing the key-value pairs from the specified table and columns, or null if no
         /// properties are found.</returns>
         /// <exception cref="InvalidDataException">Thrown if the specified table or column indices are not found in the database.</exception>
-        public static IReadOnlyDictionary<string, string>? GetMsiTableDictionary(string szDatabasePath, string table, int keyColumn, int valueColumn, params IReadOnlyList<string>? szTransformFiles)
+        public static IReadOnlyDictionary<string, string>? GetMsiTableDictionary(string szDatabasePath, string table, int keyColumn, int valueColumn, IReadOnlyList<string>? szTransformFiles = null)
         {
             // Open the database, factoring in any transforms provided, then confirm the caller input is valid.
             using MsiCloseHandleSafeHandle hDatabase = OpenDatabase(szDatabasePath, szTransformFiles);
@@ -112,7 +112,7 @@ public static class MsiUtilities
         /// <returns>A read-only list of strings containing the values from the specified column in the specified table. The list
         /// will be empty if the table contains no rows.</returns>
         /// <exception cref="InvalidDataException">Thrown if the specified table or column does not exist in the database.</exception>
-        public static IReadOnlyList<string> GetMsiTableColumnValues(string szDatabasePath, string table, int column, params IReadOnlyList<string>? szTransformFiles)
+        public static IReadOnlyList<string> GetMsiTableColumnValues(string szDatabasePath, string table, int column, IReadOnlyList<string>? szTransformFiles = null)
         {
             // Open the database, factoring in any transforms provided, then confirm the caller input is valid.
             using MsiCloseHandleSafeHandle hDatabase = OpenDatabase(szDatabasePath, szTransformFiles);
@@ -220,7 +220,7 @@ public static void CreatePropertyTransformFile(string msiPath, string newTransfo
                 using MsiCloseHandleSafeHandle hDatabaseOrig = OpenDatabase(msiPath, MSI_PERSISTENCE_MODE.MSIDBOPEN_READONLY);
 
                 // Open temp in transact mode so we can modify + commit.
-                using (MsiCloseHandleSafeHandle hDatabaseTemp = !string.IsNullOrWhiteSpace(applyTransformPath) ? OpenDatabase(tempMsiPath, MSI_PERSISTENCE_MODE.MSIDBOPEN_TRANSACT, applyTransformPath!) : OpenDatabase(tempMsiPath, MSI_PERSISTENCE_MODE.MSIDBOPEN_TRANSACT))
+                using (MsiCloseHandleSafeHandle hDatabaseTemp = !string.IsNullOrWhiteSpace(applyTransformPath) ? OpenDatabase(tempMsiPath, MSI_PERSISTENCE_MODE.MSIDBOPEN_TRANSACT, [applyTransformPath!]) : OpenDatabase(tempMsiPath, MSI_PERSISTENCE_MODE.MSIDBOPEN_TRANSACT))
                 {
                     // One view, executed once, then assign repeatedly. No string interpolation of keys/values; we use records.
                     _ = NativeMethods.MsiDatabaseOpenView(hDatabaseTemp, "SELECT `Property`,`Value` FROM `Property`", out MsiCloseHandleSafeHandle hView);
@@ -472,7 +472,7 @@ static byte ReadByteFromSwappedPair(ReadOnlySpan<char> s32, int p)
         /// <param name="szTransformFiles">An optional collection of transformation file paths to apply to the database. Transforms cannot be applied
         /// to patch files.</param>
         /// <returns>A handle to the opened database. This handle must be disposed of when no longer needed.</returns>
-        internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, MSI_PERSISTENCE_MODE? szPersist = null, params IReadOnlyList<string>? szTransformFiles)
+        internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, MSI_PERSISTENCE_MODE? szPersist = null, IReadOnlyList<string>? szTransformFiles = null)
         {
             // Open the msi/msp as a database.
             bool isPatchFile = Path.GetExtension(szDatabasePath).Equals(".msp", StringComparison.OrdinalIgnoreCase);
@@ -520,7 +520,7 @@ internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, MSI
         /// valid and accessible. May be null.</param>
         /// <returns>A safe handle representing the opened database. The caller is responsible for closing the handle to release
         /// resources.</returns>
-        internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, params IReadOnlyList<string>? szTransformFiles)
+        internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, IReadOnlyList<string>? szTransformFiles = null)
         {
             return OpenDatabase(szDatabasePath, null, szTransformFiles);
         }
@@ -537,7 +537,7 @@ internal static MsiCloseHandleSafeHandle OpenDatabase(string szDatabasePath, par
         /// information. If null, no transforms are applied.</param>
         /// <returns>A safe handle to the summary information stream of the specified database. The caller is responsible for
         /// disposing of the handle when it is no longer needed.</returns>
-        internal static MsiCloseHandleSafeHandle GetSummaryInformation(string szDatabasePath, params IReadOnlyList<string>? szTransformFiles)
+        internal static MsiCloseHandleSafeHandle GetSummaryInformation(string szDatabasePath, IReadOnlyList<string>? szTransformFiles = null)
         {
             using MsiCloseHandleSafeHandle hDatabase = OpenDatabase(szDatabasePath, szTransformFiles);
             _ = NativeMethods.MsiGetSummaryInformation(hDatabase, 0, out MsiCloseHandleSafeHandle hSummaryInfo);

src/PSADT/PSAppDeployToolkit/Foundation/DeploymentSession.cs

@@ -389,7 +389,7 @@ public DeploymentSession(IReadOnlyDictionary<string, object>? parameters = null,
                         // Generate list of MSI executables for use with Show-ADTInstallationWelcome.
                         if (!Settings.HasFlag(DeploymentSettings.DisableDefaultMsiProcessList))
                         {
-                            ProcessDefinition[] msiExecList = [.. (!string.IsNullOrWhiteSpace(DefaultMstFile) ? MsiUtilities.GetMsiTableColumnValues(DefaultMsiFile!, "File", 3, DefaultMstFile!) : MsiUtilities.GetMsiTableColumnValues(DefaultMsiFile!, "File", 3)).Where(static p => p.EndsWith(".exe", StringComparison.OrdinalIgnoreCase)).Select(static p => new ProcessDefinition(Path.GetFileNameWithoutExtension(p.Split(['|'], StringSplitOptions.RemoveEmptyEntries).Last())))];
+                            ProcessDefinition[] msiExecList = [.. (!string.IsNullOrWhiteSpace(DefaultMstFile) ? MsiUtilities.GetMsiTableColumnValues(DefaultMsiFile!, "File", 3, [DefaultMstFile!]) : MsiUtilities.GetMsiTableColumnValues(DefaultMsiFile!, "File", 3)).Where(static p => p.EndsWith(".exe", StringComparison.OrdinalIgnoreCase)).Select(static p => new ProcessDefinition(Path.GetFileNameWithoutExtension(p.Split(['|'], StringSplitOptions.RemoveEmptyEntries).Last())))];
                             if (msiExecList.Length > 0)
                             {
                                 AppProcessesToClose = new ReadOnlyCollection<ProcessDefinition>([.. AppProcessesToClose.Concat(msiExecList).GroupBy(static p => p.Name, StringComparer.OrdinalIgnoreCase).Select(static g => g.First())]);
@@ -398,7 +398,7 @@ public DeploymentSession(IReadOnlyDictionary<string, object>? parameters = null,
                         }
 
                         // Update our app variables with new values.
-                        IReadOnlyDictionary<string, string> msiProps = (!string.IsNullOrWhiteSpace(DefaultMstFile) ? MsiUtilities.GetMsiTableDictionary(DefaultMsiFile!, "Property", 1, 2, DefaultMstFile!) : MsiUtilities.GetMsiTableDictionary(DefaultMsiFile!, "Property", 1, 2))!;
+                        IReadOnlyDictionary<string, string> msiProps = (!string.IsNullOrWhiteSpace(DefaultMstFile) ? MsiUtilities.GetMsiTableDictionary(DefaultMsiFile!, "Property", 1, 2, [DefaultMstFile!]) : MsiUtilities.GetMsiTableDictionary(DefaultMsiFile!, "Property", 1, 2))!;
                         if (string.IsNullOrWhiteSpace(AppVendor))
                         {
                             AppVendor = msiProps["Manufacturer"];