new icon: nasm (original, original-wordmark, plain, plain-wordmark)#2212
Merged
weh merged 4 commits intodevicons:developfrom Sep 27, 2025
Merged
new icon: nasm (original, original-wordmark, plain, plain-wordmark)#2212weh merged 4 commits intodevicons:developfrom
weh merged 4 commits intodevicons:developfrom
Conversation
Contributor
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Snailedlt
reviewed
Jun 2, 2025
Collaborator
|
@canaleal other than the conflicts in devicon.json this looks fine. Please fix the conflicts when you have time :) |
weh
previously approved these changes
Jun 4, 2025
Contributor
weh
left a comment
There was a problem hiding this comment.
I added the deleted quotation mark. The rest looks perfect.
weh
approved these changes
Sep 27, 2025
Contributor
weh
left a comment
There was a problem hiding this comment.
fixed the conflict in devicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1749
Link to prove your SVG is correct and up-to-date.
The color
#113b6awas selected for the font SVGs as it's the main color in the original logo.