Skip to content

Commit acea393

Browse files
committed
load after build for buildx
Signed-off-by: David Justice <david@devigned.com>
1 parent e6c70d8 commit acea393

2 files changed

Lines changed: 26 additions & 18 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,10 @@ jobs:
1212
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- name: Set up Docker
16-
uses: docker/setup-docker-action@v4
17-
with:
18-
version: type=image,tag=latest
19-
daemon-config: |
20-
{
21-
"debug": true,
22-
"features": {
23-
"containerd-snapshotter": true
24-
}
25-
}
15+
- name: Set up QEMU
16+
uses: docker/setup-qemu-action@v3
17+
- name: Set up Docker Buildx
18+
uses: docker/setup-buildx-action@v3
2619
- name: Checkout
2720
uses: actions/checkout@v4
2821
- name: setup-tools

base-images/build.sh

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env bash
2-
set -e
2+
set -euo pipefail
33

44
DEFAULT_PREFIX=wasm/demo-base
55
DEFAULT_PLATFORM="linux/amd64,linux/arm64"
@@ -50,25 +50,38 @@ fi
5050

5151
cd $(dirname $0)
5252

53-
IMAGE_DIR=$(realpath "${BASE_DIR}")
54-
TAG=$(basename "${IMAGE_DIR}")
53+
TAG="${ENV_VAR:-latest}"
5554
BASE_IMAGE=heroku/heroku:24-build
5655
RUN_IMAGE=${REPO_PREFIX}-run:${TAG}
5756
BUILD_IMAGE=${REPO_PREFIX}-build:${TAG}
5857

58+
docker buildx ls
59+
5960
echo "BUILDING ${BUILD_IMAGE}..."
60-
docker buildx build --load \
61+
docker buildx build \
6162
--platform "${PLATFORM}" \
6263
--build-arg "BASE_IMAGE=${BASE_IMAGE}" \
6364
-t "${BUILD_IMAGE}" \
64-
"${IMAGE_DIR}/build"
65+
"${BASE_DIR}/build"
6566

66-
echo "BUILDING ${RUN_IMAGE}..."
6767
docker buildx build --load \
68+
--build-arg "BASE_IMAGE=${BASE_IMAGE}" \
69+
-t "${BUILD_IMAGE}" \
70+
"${BASE_DIR}/build"
71+
72+
docker buildx build --load -t "${BUILD_IMAGE}" ${BASE_DIR}/build
73+
74+
echo "BUILDING ${RUN_IMAGE}..."
75+
docker buildx build \
6876
--platform "${PLATFORM}" \
6977
--build-arg "BASE_IMAGE=${BUILD_IMAGE}" \
7078
-t "${RUN_IMAGE}" \
71-
"${IMAGE_DIR}/run"
79+
"${BASE_DIR}/run"
80+
81+
docker buildx build --load \
82+
--build-arg "BASE_IMAGE=${BUILD_IMAGE}" \
83+
-t "${RUN_IMAGE}" \
84+
"${BASE_DIR}/run"
7285

7386
echo
7487
echo "BASE IMAGES BUILT!"
@@ -77,3 +90,5 @@ echo "Images:"
7790
for IMAGE in "${BASE_IMAGE}" "${BUILD_IMAGE}" "${RUN_IMAGE}"; do
7891
echo " ${IMAGE}"
7992
done
93+
94+
docker image ls

0 commit comments

Comments
 (0)