feat(v2): Add FmdClient/Device package with full API port and tests#1
Closed
Copilot wants to merge 2 commits into
Closed
feat(v2): Add FmdClient/Device package with full API port and tests#1Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…and add tests Co-authored-by: devinslick <1762071+devinslick@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add fmd_api v2 implementation with core behaviors and tests
feat(v2): Add FmdClient/Device package with full API port and tests
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements v2 package structure with
FmdClient(low-level API) andDevice(high-level wrapper) classes, porting all core behaviors from the existingfmd_api.pymodule while preserving authentication flow, encryption/decryption semantics, and API compatibility.Package Structure
Constants Preserved
All existing constants maintained (ARGON2 params, context strings, RSA key size 384 bytes, IV sizes 12 bytes).
Migration & Examples
FmdApi.get_all_locations()→FmdClient.get_locations()/Device.get_history()Tests
22 pytest-asyncio tests (aioresponses for HTTP mocking):
Usage
Changes to pyproject.toml
requestsdependencyaioresponsesto dev dependenciesOriginal prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.