Increase test coverage to 98%: add comprehensive unit tests for client/device, retries, and export paths#5
Merged
devinslick merged 1 commit intomainfrom Nov 6, 2025
Conversation
…nd publish correct artifact
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version number of the fmd_api package from 2.0.1 to 2.0.2, indicating a patch release.
- Version bump from 2.0.1 to 2.0.2 in the project metadata
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase test coverage to 98%: add comprehensive unit tests for client/device, retries, and export paths
Summary
fmd_api.clientandfmd_api.deviceWhat changed
tests/unit/test_coverage_improvements.py:coverage.xmlgenerated for CodecovWhy
Metrics
client.py~77%,device.py~94%)client.py~97%,device.py100%)Compatibility
How to validate locally (optional)
Notes and follow-ups
client.py(e.g., specific fallback/log-only segments):353–358,368,392–393,477–478,563,717–718aiohttpresponse mocking or small refactors to expose those branches for deterministic testing; can be tackled in a follow-up if desiredChecklist
coverage.xmlupdated for CI/Codecov