Skip to content

Commit 8b4a3ef

Browse files
committed
Fix validation issues: macros, alerts, indexes, and documentation
Fixes: - indexes.conf: Remove empty coldToFrozenDir that caused invalid config - macros.conf: Fix return syntax (add closing $ to $setting_value$) - macros.conf: Change first() to sum() for metric aggregation in 4 macros (get_all_dashboards_summary, get_all_dashboards_summary_timerange, get_problematic_dashboards, get_dashboard_engagement_scores) - macros.conf: Use settings lookup for engagement scoring weights - savedsearches.conf: Fix alerts to not truncate results with head 1 - README.md: Correct statement about enabled searches https://claude.ai/code/session_014YNv3fKbpjQB5eMZCrHwzi
1 parent a24ebc0 commit 8b4a3ef

4 files changed

Lines changed: 17 additions & 17 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ We welcome contributions for any of these roadmap items or new feature ideas. Pl
639639
- Better error handling in all collectors
640640
- More robust field extraction in data collection
641641
- Improved performance with tsidx reduction enabled
642-
- All scheduled searches now enabled by default
642+
- Core data collection searches enabled by default (alerts and reports disabled by default)
643643

644644
#### Breaking Changes
645645
- App version bumped from 0.0.1 to 1.0.0

default/indexes.conf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ thawedPath = $SPLUNK_DB/caca_metrics/thaweddb
1111
# Adjust based on your retention requirements
1212
frozenTimePeriodInSecs = 31536000
1313

14-
# Roll buckets to cold after 30 days for storage efficiency
15-
coldToFrozenDir =
14+
# Bucket management settings
1615
maxWarmDBCount = 300
1716

1817
# Enable tsidx reduction for better metric performance

default/macros.conf

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ iseval = 0
1717
[caca_get_setting(1)]
1818
args = setting_name
1919
definition = | inputlookup caca_settings where setting_name="$setting_name$" \
20-
| return $setting_value
20+
| return $setting_value$
2121
iseval = 0
2222

2323
#####################
@@ -64,10 +64,8 @@ definition = | mstats sum(_value) as metric_value WHERE index=caca_metrics AND m
6464
metric_name=="dashboard.load_time", "load_time_7d",\
6565
1=1, "other") \
6666
| eval {metric_type}=total_value \
67-
| stats values(app) as app first(views_7d) as views_7d first(edits_7d) as edits_7d first(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name \
67+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name \
6868
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d \
69-
| lookup caca_settings setting_name AS tmp OUTPUT setting_value AS tmp2 \
70-
| lookup caca_settings setting_name OUTPUT setting_value \
7169
| appendpipe [| inputlookup caca_settings | eval {setting_name}=setting_value | stats values(*) as * | eval _merge="settings"] \
7270
| eventstats values(error_threshold_warning) as _warn_thresh values(error_threshold_critical) as _crit_thresh \
7371
| where isnotnull(pretty_name) \
@@ -92,7 +90,7 @@ definition = | mstats sum(_value) as metric_value WHERE index=caca_metrics AND m
9290
metric_name=="dashboard.load_time", "load_time",\
9391
1=1, "other") \
9492
| eval {metric_type}=total_value \
95-
| stats values(app) as app first(views) as views first(edits) as edits first(errors) as errors avg(load_time) as avg_load_time by pretty_name \
93+
| stats values(app) as app sum(views) as views sum(edits) as edits sum(errors) as errors avg(load_time) as avg_load_time by pretty_name \
9694
| fillnull value=0 views edits errors avg_load_time
9795
iseval = 0
9896

@@ -229,7 +227,7 @@ definition = | mstats sum(_value) as metric_value WHERE index=caca_metrics AND m
229227
metric_name=="dashboard.load_time", "load_time_7d",\
230228
1=1, "other") \
231229
| eval {metric_type}=total_value \
232-
| stats values(app) as app first(views_7d) as views_7d first(edits_7d) as edits_7d first(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name \
230+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name \
233231
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d \
234232
| eval health_status=case(\
235233
errors_7d > 10, "critical",\
@@ -297,10 +295,15 @@ definition = | mstats sum(_value) as metric_value WHERE index=caca_metrics AND m
297295
metric_name=="dashboard.errors", "errors",\
298296
1=1, "other") \
299297
| eval {metric_type}=total \
300-
| stats values(app) as app first(views) as views_30d first(edits) as edits_30d first(errors) as errors_30d by pretty_name \
298+
| stats values(app) as app sum(views) as views_30d sum(edits) as edits_30d sum(errors) as errors_30d by pretty_name \
301299
| fillnull value=0 views_30d edits_30d errors_30d \
302-
| eval engagement_score=views_30d + (edits_30d * 2) - (errors_30d * 5) \
300+
| appendpipe [| inputlookup caca_settings | eval {setting_name}=setting_value | stats values(*) as * | eval _merge="settings"] \
301+
| eventstats values(engagement_edit_weight) as _edit_weight values(engagement_error_penalty) as _error_penalty \
302+
| where isnotnull(pretty_name) \
303+
| eval _edit_weight=coalesce(_edit_weight, 2), _error_penalty=coalesce(_error_penalty, 5) \
304+
| eval engagement_score=views_30d + (edits_30d * _edit_weight) - (errors_30d * _error_penalty) \
303305
| eval engagement_score=if(engagement_score < 0, 0, engagement_score) \
306+
| fields - _edit_weight _error_penalty _merge \
304307
| sort -engagement_score \
305308
| lookup dashboard_registry pretty_name OUTPUT owner description
306309
iseval = 0

default/savedsearches.conf

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,11 +213,10 @@ dispatch.latest_time = now
213213
enableSched = 0
214214
search = | mstats sum(_value) as error_count WHERE index=caca_metrics AND metric_name="dashboard.errors" BY pretty_name, app span=1h \
215215
| stats sum(error_count) as total_errors by pretty_name, app \
216-
| lookup caca_settings setting_name OUTPUT setting_value \
217-
| head 1 \
218-
| appendpipe [| inputlookup caca_settings where setting_name="error_threshold_critical" | head 1] \
216+
| appendpipe [| inputlookup caca_settings where setting_name="error_threshold_critical" | eval _merge="settings"] \
219217
| eventstats values(setting_value) as critical_threshold \
220218
| where isnotnull(pretty_name) AND total_errors >= coalesce(critical_threshold, 10) \
219+
| fields - critical_threshold _merge setting_name setting_value setting_description \
221220
| lookup dashboard_registry pretty_name OUTPUT owner \
222221
| table pretty_name app owner total_errors
223222
schedule_priority = default
@@ -238,12 +237,11 @@ dispatch.latest_time = now
238237
enableSched = 0
239238
search = | mstats avg(_value) as avg_load WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1h \
240239
| stats avg(avg_load) as avg_load_time by pretty_name, app \
241-
| lookup caca_settings setting_name OUTPUT setting_value \
242-
| head 1 \
243-
| appendpipe [| inputlookup caca_settings where setting_name="load_time_critical" | head 1] \
240+
| appendpipe [| inputlookup caca_settings where setting_name="load_time_critical" | eval _merge="settings"] \
244241
| eventstats values(setting_value) as critical_threshold \
245242
| where isnotnull(pretty_name) AND avg_load_time >= coalesce(critical_threshold, 10000) \
246243
| eval avg_load_time=round(avg_load_time, 0) \
244+
| fields - critical_threshold _merge setting_name setting_value setting_description \
247245
| lookup dashboard_registry pretty_name OUTPUT owner \
248246
| table pretty_name app owner avg_load_time
249247
schedule_priority = default

0 commit comments

Comments
 (0)