Skip to content

Commit d96e41c

Browse files
Copilotdevinslick
Copilot
and
devinslick
committed
Fix mcollect syntax and performance metric collection
Co-authored-by: devinslick <1762071+devinslick@users.noreply.github.com>
1 parent fa6a04d commit d96e41c

5 files changed

Lines changed: 21 additions & 33 deletions

File tree

‎default/data/ui/views/dashboard_details.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,16 +143,16 @@
143143
<title>Load Time Trend Over Time</title>
144144
<chart>
145145
<search>
146-
<query>| mstats avg(avg_load_time) as avg_load, max(max_load_time) as max_load WHERE index=caca_metrics AND pretty_name="$dashboard_name$" AND metric_name="dashboard.load_time" span=1h
147-
| timechart avg(avg_load) as "Avg Load Time (ms)" max(max_load) as "Max Load Time (ms)" span=1h</query>
146+
<query>| mstats avg(_value) as avg_load WHERE index=caca_metrics AND pretty_name="$dashboard_name$" AND metric_name="dashboard.load_time" span=1h
147+
| timechart avg(avg_load) as "Avg Load Time (ms)" span=1h</query>
148148
<earliest>$time_range.earliest$</earliest>
149149
<latest>$time_range.latest$</latest>
150150
</search>
151151
<option name="charting.chart">line</option>
152152
<option name="charting.axisTitleX.text">Date</option>
153153
<option name="charting.axisTitleY.text">Load Time (ms)</option>
154154
<option name="charting.legend.placement">bottom</option>
155-
<option name="charting.seriesColors">[0xF8BE34,0xDC4E41]</option>
155+
<option name="charting.seriesColors">[0xF8BE34]</option>
156156
<option name="charting.drilldown">none</option>
157157
</chart>
158158
</panel>

‎default/data/ui/views/dashboard_leaderboard.xml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
<search>
226226
<query>`get_slow_dashboards`
227227
| head 10
228-
| rename pretty_name as "Dashboard", app as "App", avg_load_time_7d as "Avg Load (ms)", max_load_time_7d as "Max Load (ms)", performance_status as "Status"</query>
228+
| rename pretty_name as "Dashboard", app as "App", avg_load_time_7d as "Avg Load (ms)", performance_status as "Status"</query>
229229
<earliest>-7d@h</earliest>
230230
<latest>now</latest>
231231
</search>
@@ -237,9 +237,6 @@
237237
<format type="number" field="Avg Load (ms)">
238238
<option name="precision">0</option>
239239
</format>
240-
<format type="number" field="Max Load (ms)">
241-
<option name="precision">0</option>
242-
</format>
243240
<drilldown>
244241
<link target="_blank">/app/splunk-content-monitoring-console/dashboard_details?form.dashboard_name=$row.Dashboard$</link>
245242
</drilldown>

‎default/data/ui/views/poop_deck.xml‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -285,12 +285,11 @@
285285
<title>🐌 The Slow - Dashboards with Performance Issues (Last 7 Days)</title>
286286
<table>
287287
<search>
288-
<query>| mstats avg(avg_load_time) as avg_load, max(max_load_time) as max_load WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1d
288+
<query>| mstats avg(_value) as avg_load WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1d
289289
| where _time >= relative_time(now(), "-7d")
290-
| stats avg(avg_load) as avg_load_time, max(max_load) as max_load_time by pretty_name, app
290+
| stats avg(avg_load) as avg_load_time by pretty_name, app
291291
| where avg_load_time &gt; 3000
292292
| eval avg_load_time=round(avg_load_time, 0)
293-
| eval max_load_time=round(max_load_time, 0)
294293
| lookup dashboard_registry pretty_name OUTPUT owner description
295294
| join type=left pretty_name
296295
[| mstats sum(_value) as views WHERE index=caca_metrics AND metric_name="dashboard.views" BY pretty_name span=1d
@@ -312,8 +311,8 @@
312311
avg_load_time &gt; 7000, "High priority optimization",
313312
avg_load_time &gt; 5000, "Should optimize",
314313
1=1, "Consider optimization")
315-
| table pretty_name app avg_load_time max_load_time views_7d performance_level user_impact recommendation owner description
316-
| rename pretty_name as "Dashboard", app as "App", avg_load_time as "Avg Load (ms)", max_load_time as "Max Load (ms)", views_7d as "Views (7d)", performance_level as "Performance", user_impact as "Impact", recommendation as "Recommendation", owner as "Owner", description as "Description"
314+
| table pretty_name app avg_load_time views_7d performance_level user_impact recommendation owner description
315+
| rename pretty_name as "Dashboard", app as "App", avg_load_time as "Avg Load (ms)", views_7d as "Views (7d)", performance_level as "Performance", user_impact as "Impact", recommendation as "Recommendation", owner as "Owner", description as "Description"
317316
| sort -"Avg Load (ms)"</query>
318317
<earliest>-7d@d</earliest>
319318
<latest>now</latest>
@@ -326,12 +325,6 @@
326325
<format type="number" field="Avg Load (ms)">
327326
<option name="precision">0</option>
328327
</format>
329-
<format type="number" field="Max Load (ms)">
330-
<option name="precision">0</option>
331-
</format>
332-
<format type="number" field="Views (7d)">
333-
<option name="precision">0</option>
334-
</format>
335328
<format type="number" field="Views (7d)">
336329
<option name="precision">0</option>
337330
</format>

‎default/macros.conf‎

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,27 +70,25 @@ iseval = 0
7070

7171
[get_dashboard_performance(1)]
7272
args = dashboard_name
73-
definition = | mstats avg(avg_load_time) as avg_load_time, max(max_load_time) as max_load_time WHERE index=caca_metrics AND pretty_name="$dashboard_name$" AND metric_name="dashboard.load_time" BY pretty_name span=1h \
73+
definition = | mstats avg(_value) as avg_load_time WHERE index=caca_metrics AND pretty_name="$dashboard_name$" AND metric_name="dashboard.load_time" BY pretty_name span=1h \
7474
| eval avg_load_time=round(avg_load_time, 2) \
75-
| eval max_load_time=round(max_load_time, 2) \
7675
| eval performance_rating=case(\
77-
avg_load_time < 1000, "Excellent",\
78-
avg_load_time < 3000, "Good",\
79-
avg_load_time < 5000, "Fair",\
76+
avg_load_time &lt; 1000, "Excellent",\
77+
avg_load_time &lt; 3000, "Good",\
78+
avg_load_time &lt; 5000, "Fair",\
8079
1=1, "Poor")
8180
iseval = 0
8281

8382
[get_slow_dashboards]
84-
definition = | mstats avg(avg_load_time) as avg_load_time, max(max_load_time) as max_load_time WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1d \
83+
definition = | mstats avg(_value) as avg_load_time WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1d \
8584
| where _time >= relative_time(now(), "-7d") \
86-
| stats avg(avg_load_time) as avg_load_time_7d, max(max_load_time) as max_load_time_7d by pretty_name, app \
87-
| where avg_load_time_7d > 3000 \
85+
| stats avg(avg_load_time) as avg_load_time_7d by pretty_name, app \
86+
| where avg_load_time_7d &gt; 3000 \
8887
| eval avg_load_time_7d=round(avg_load_time_7d, 0) \
89-
| eval max_load_time_7d=round(max_load_time_7d, 0) \
9088
| eval performance_status=case(\
91-
avg_load_time_7d > 10000, "Critical",\
92-
avg_load_time_7d > 5000, "Poor",\
93-
avg_load_time_7d > 3000, "Fair",\
89+
avg_load_time_7d &gt; 10000, "Critical",\
90+
avg_load_time_7d &gt; 5000, "Poor",\
91+
avg_load_time_7d &gt; 3000, "Fair",\
9492
1=1, "Good") \
9593
| sort -avg_load_time_7d
9694
iseval = 0

‎default/savedsearches.conf‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ search = index=_internal sourcetype=splunkd_ui_access uri_path="/*/app/*" \
8585
| where isnotnull(pretty_name) \
8686
| eval load_time_ms=tonumber(spent) \
8787
| where isnotnull(load_time_ms) AND load_time_ms > 0 \
88-
| stats avg(load_time_ms) as avg_load_time, max(load_time_ms) as max_load_time, count as request_count by dashboard_uri, pretty_name, app, user \
88+
| stats sum(load_time_ms) as total_load_time, count as request_count by dashboard_uri, pretty_name, app, user \
89+
| eval avg_load_time=round(total_load_time/request_count, 2) \
8990
| eval metric_name="dashboard.load_time" \
9091
| eval activity_type="performance" \
91-
| foreach avg_load_time max_load_time [ eval <<FIELD>>=round(<<FIELD>>, 2) ] \
92-
| mcollect index=caca_metrics metric_name=metric_name pretty_name app user activity_type avg_load_time max_load_time split=t
92+
| mcollect index=caca_metrics metric_name=metric_name _value=avg_load_time pretty_name app user activity_type split=t
9393
schedule_priority = low
9494
schedule_window = 5
9595

0 commit comments

Comments
 (0)