Skip to content

Commit 35788f4

Browse files
committed
misc: Notes
1 parent 34edaca commit 35788f4

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

devito/ir/clusters/algorithms.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ def callback(self, clusters, prefix, backlog=None, known_break=None):
157157
# parallelism
158158
for i in range(1, len(clusters)):
159159
# FIXME: This eats a lot of time (four seconds each time)
160+
# FIXME: Pull scope out of this
160161
if self._break_for_parallelism(scope, candidates, i):
161162
return self.callback(clusters[:i], prefix, clusters[i:] + backlog,
162163
candidates | known_break)
@@ -194,6 +195,7 @@ def _break_for_parallelism(self, scope, candidates, i):
194195
# break parallelism
195196

196197
# TODO: Can this loop be made to short-circuit?
198+
# TODO: Most of the time is burned in d_from_access_gen
197199
test = False
198200
for d in scope.d_from_access_gen(scope.a_query(i)):
199201
if d.is_local or d.is_storage_related(candidates):

devito/ir/support/basic.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,6 +1170,7 @@ def d_from_access_gen(self, accesses):
11701170
Generate all flow, anti, and output dependences involving any of
11711171
the given TimedAccess objects.
11721172
"""
1173+
# FIXME: This seems to be a hotspot
11731174
accesses = as_tuple(accesses)
11741175
for d in self.d_all_gen():
11751176
for i in accesses:

0 commit comments

Comments
 (0)