tests: test installed sympy version

Author: mloubout

.github/workflows/pytest-core-nompi.yml

@@ -166,6 +166,16 @@ jobs:
         python3 -m pip install ${{ env.PIPFLAGS }} sympy==${{matrix.sympy}}
         python3 -m pip install ${{ env.PIPFLAGS }} -e .[tests,extras]
 
+    - name: Check sympy version
+      if: "!contains(matrix.name, 'docker')"
+      run: |
+        full=$(pip show sympy | awk '/^Version:/ {print $2}')
+        majmin=${full%.*}
+        if [[ $majmin != ${{ matrix.sympy }} ]]; then
+          echo "::error::Sympy version mismatch: expected" ${{ matrix.sympy }} " got " $full
+          exit 1
+        fi
+
     - name: Check configuration
       run: |
         ${{ env.RUN_CMD }} python3 -c "from devito import configuration; print(''.join(['%s: %s \n' % (k, v) for (k, v) in configuration.items()]))"

pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["setuptools>=42", "wheel", "sympy"]
+build-backend = "setuptools.build_meta"

setup.py

@@ -1,16 +1,6 @@
 import versioneer
 from packaging.version import Version
 import os
-
-try:
-    import importlib.metadata as metadata
-    get_version = lambda x: metadata.version(x)
-    PkgNotFound = metadata.PackageNotFoundError
-except ImportError:
-    import pkg_resources
-    get_version = lambda x: pkg_resources.get_distribution(x).version
-    PkgNotFound = pkg_resources.DistributionNotFound
-
 from setuptools import setup, find_packages
 
 
@@ -25,21 +15,21 @@ def min_max(pkgs, pkg_name):
 
 def numpy_compat(required):
     new_reqs = [r for r in required if "numpy" not in r and "sympy" not in r]
-    sympy_lb, sympy_ub = min_max(required, "sympy")
     numpy_lb, numpy_ub = min_max(required, "numpy")
 
     # Due to api changes in numpy 2.0, it requires sympy 1.12.1 at the minimum
     # Check if sympy is installed and enforce numpy version accordingly.
     # If sympy isn't installed, enforce sympy>=1.12.1 and numpy>=2.0
-    try:
-        sympy_version = Version(get_version("sympy"))
-        min_ver2 = Version("1.12.1")
-        if sympy_version < min_ver2:
-            new_reqs.extend([f"numpy>{numpy_lb},<2.0", f"sympy=={sympy_version}"])
-        else:
-            new_reqs.extend([f"numpy>=2.0,<{numpy_ub}", f"sympy=={sympy_version}"])
-    except PkgNotFound:
-        new_reqs.extend([f"sympy>=1.12.1,<{sympy_ub}", f"numpy>=2.0,<{numpy_ub}"])
+    # try:
+    import sympy
+    sympy_version = Version(sympy.__version__)
+    min_ver2 = Version("1.12.1")
+    if sympy_version < min_ver2:
+        new_reqs.extend([f"numpy>{numpy_lb},<2.0", f"sympy=={sympy_version}"])
+    else:
+        new_reqs.extend([f"numpy>=2.0,<{numpy_ub}", f"sympy=={sympy_version}"])
+    # except ImportError:
+    #     new_reqs.extend([f"sympy>=1.12.1,<{sympy_ub}", f"numpy>=2.0,<{numpy_ub}"])
 
     return new_reqs