compiler: Refactor clean-up

Author: FabioLuporini

devito/ir/iet/nodes.py

@@ -1683,7 +1683,7 @@ def _same_as_before(old, new):
     if type(old) is not type(new):
         return False
 
-    if isinstance(old, dict):
+    if isinstance(old, dict) and isinstance(new, dict):
         return old.keys() == new.keys() and all(
             _same_as_before(v, new[k]) for k, v in old.items()
         )

devito/ir/iet/visitors.py

@@ -1560,14 +1560,10 @@ def visit_KernelLaunch(self, o):
 
 
 def reuse_if_unchanged(o, *children, **kwargs):
-    if children:
-        same_children = all(
-            _same_as_before(i, j) for i, j in zip(o.children, children, strict=True)
-        )
-        if not same_children:
-            return o._rebuild(*children, **kwargs)
-
-    if kwargs and not all(o._same_arg(k, v) for k, v in kwargs.items()):
+    if children and not _same_as_before(o.children, children):
+        return o._rebuild(*children, **kwargs)
+
+    if kwargs:
         return o._rebuild(*children, **kwargs)
 
     return o

devito/ir/support/basic.py

@@ -218,9 +218,7 @@ class TimedAccess(IterationInstance, AccessMode, CacheInstances):
     """
 
     @classmethod
-    def _preprocess_args(cls, access, mode, timestamp, ispace=None):
-        if ispace is None:
-            ispace = null_ispace
+    def _preprocess_args(cls, access, mode, timestamp, ispace=null_ispace):
         return (access, mode, timestamp, ispace), {}
 
     def __new__(cls, access, mode, timestamp, ispace=None):

devito/passes/clusters/fusion.py

@@ -24,6 +24,9 @@
 
 @memoized_func(scope='build')
 def _fusion_hazards(scope0, scope1, prefix):
+    """
+    Classify the dependence hazard that would arise from fusing two scopes.
+    """
     scope = Scope.from_scopes(scope0, scope1)
     if scope is None:
         return NO_HAZARD