Skip to content

Commit 5f58c84

Browse files
committed
refactor: replace n_timesteps by cp_timesteps or op_timesteps
1 parent f79744b commit 5f58c84

1 file changed

Lines changed: 20 additions & 27 deletions

File tree

pyrevolve/pyrevolve.py

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def __init__(
7070
fwd_operator,
7171
rev_operator,
7272
n_checkpoints,
73-
n_timesteps,
73+
op_timesteps,
7474
storage_list=None,
7575
scheduler=None,
7676
timings=None,
@@ -84,10 +84,10 @@ def __init__(
8484
methods and a scheduler object must be provided as well. Otherwise
8585
NumpyStorage and CRevolve are used as default
8686
"""
87-
if n_timesteps is None:
87+
if op_timesteps is None:
8888
raise Exception(
8989
"Online checkpointing not yet supported. Specify \
90-
number of time steps!"
90+
number of Operator time steps!"
9191
)
9292

9393
if profiler is None:
@@ -103,12 +103,14 @@ def __init__(
103103
self.checkpoint = checkpoint
104104
self.n_checkpoints = n_checkpoints
105105
self.block_size = block_size
106-
self.n_timesteps = n_timesteps
106+
self.op_timesteps = op_timesteps
107107
self.timings = timings
108108
self.fwd_operator = fwd_operator
109109
self.rev_operator = rev_operator
110110
self.scheduler = scheduler
111111

112+
self.cp_timesteps = int(math.ceil(self.op_timesteps / self.block_size))
113+
112114
def addStorage(self, new_storage):
113115
self.storage_list.append(new_storage)
114116

@@ -174,15 +176,6 @@ def addByteStorage(self, compression_params):
174176
def makespan(self):
175177
return 0
176178

177-
@property
178-
def n_timesteps(self):
179-
return self._n_timesteps
180-
181-
@n_timesteps.setter
182-
def n_timesteps(self, n_timesteps):
183-
self.op_timesteps = n_timesteps
184-
self._n_timesteps = int(math.ceil(n_timesteps / self.block_size))
185-
186179
@property
187180
def op_old_capo(self):
188181
return self.scheduler.old_capo * self.block_size
@@ -320,7 +313,7 @@ def __init__(
320313
fwd_operator,
321314
rev_operator,
322315
n_checkpoints,
323-
n_timesteps,
316+
op_timesteps,
324317
timings=None,
325318
profiler=None,
326319
compression_params=None,
@@ -335,7 +328,7 @@ def __init__(
335328
fwd_operator: forward operator
336329
rev_operator: backward operator
337330
n_checkpoints: number of checkpoints
338-
n_timesteps: number of timesteps
331+
op_timesteps: number of timesteps
339332
timings: timings
340333
profiler: Profiler
341334
compression_params: compression scheme
@@ -348,7 +341,7 @@ def __init__(
348341
fwd_operator,
349342
rev_operator,
350343
n_checkpoints,
351-
n_timesteps,
344+
op_timesteps,
352345
timings=timings,
353346
profiler=profiler,
354347
)
@@ -357,11 +350,11 @@ def __init__(
357350
self.singlefile = singlefile
358351

359352
if n_checkpoints is None:
360-
self.n_checkpoints = cr.adjust(self.n_timesteps)
353+
self.n_checkpoints = cr.adjust(self.cp_timesteps)
361354
else:
362355
self.n_checkpoints = n_checkpoints
363356

364-
self.scheduler = CRevolve(self.n_checkpoints, self.n_timesteps)
357+
self.scheduler = CRevolve(self.n_checkpoints, self.cp_timesteps)
365358

366359
# remove storage list to avoid memory overflow
367360
self.resetStorageList()
@@ -395,7 +388,7 @@ def __init__(
395388
checkpoint,
396389
fwd_operator,
397390
rev_operator,
398-
n_timesteps,
391+
op_timesteps,
399392
storage_list,
400393
timings=None,
401394
profiler=None,
@@ -416,7 +409,7 @@ def __init__(
416409
fwd_operator: forward operator
417410
rev_operator: backward operator
418411
n_checkpoints: number of checkpoints
419-
n_timesteps: number of timesteps
412+
op_timesteps: number of timesteps
420413
timings: timings
421414
profiler: profiler
422415
storage_list: list of storage objects
@@ -428,8 +421,8 @@ def __init__(
428421
checkpoint,
429422
fwd_operator,
430423
rev_operator,
431-
n_timesteps,
432-
n_timesteps,
424+
op_timesteps,
425+
op_timesteps,
433426
storage_list=storage_list,
434427
timings=timings,
435428
profiler=profiler,
@@ -462,7 +455,7 @@ def reload_scheduler(self, uf=1, ub=1, up=1):
462455
self.up = up
463456
self.arch = Architecture(self.storage_list)
464457
self.scheduler = HRevolve(
465-
self.n_checkpoints, self.n_timesteps, self.arch, self.uf, self.ub, self.up
458+
self.n_checkpoints, self.cp_timesteps, self.arch, self.uf, self.ub, self.up
466459
)
467460
else:
468461
raise ValueError(
@@ -502,7 +495,7 @@ def __init__(
502495
fwd_operator,
503496
rev_operator,
504497
n_checkpoints,
505-
n_timesteps,
498+
op_timesteps,
506499
timings=None,
507500
profiler=None,
508501
compression_params=None,
@@ -512,7 +505,7 @@ def __init__(
512505
fwd_operator,
513506
rev_operator,
514507
n_checkpoints,
515-
n_timesteps,
508+
op_timesteps,
516509
timings=timings,
517510
profiler=profiler,
518511
compression_params=compression_params,
@@ -541,7 +534,7 @@ def __init__(
541534
fwd_operator,
542535
rev_operator,
543536
n_checkpoints,
544-
n_timesteps,
537+
op_timesteps,
545538
timings=None,
546539
profiler=None,
547540
filedir="./",
@@ -552,7 +545,7 @@ def __init__(
552545
fwd_operator,
553546
rev_operator,
554547
n_checkpoints,
555-
n_timesteps,
548+
op_timesteps,
556549
timings=timings,
557550
profiler=profiler,
558551
diskstorage=True,

0 commit comments

Comments
 (0)