Skip to content

Commit 2667700

Browse files
Merge remote-tracking branch 'upstream/master'
2 parents de1f15e + 4f0e530 commit 2667700

50 files changed

Lines changed: 408 additions & 396 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/scripts/spellcheck.words

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ Fedora
256256
Feltzing
257257
ffi
258258
filesize
259-
filesystem
260259
FindCURL
261260
FLOSS
262261
fnmatch

CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1501,12 +1501,16 @@ if(_curl_ca_bundle_supported)
15011501
set(CURL_CA_BUNDLE "auto" CACHE
15021502
STRING "Path to the CA bundle. Set 'none' to disable or 'auto' for auto-detection. Defaults to 'auto'.")
15031503
set(CURL_CA_FALLBACK OFF CACHE
1504-
BOOL "Use built-in CA store of TLS backend. Defaults to OFF")
1504+
BOOL "Use built-in CA store of OpenSSL. Defaults to OFF")
15051505
set(CURL_CA_PATH "auto" CACHE
15061506
STRING "Location of default CA path. Set 'none' to disable or 'auto' for auto-detection. Defaults to 'auto'.")
15071507
set(CURL_CA_EMBED "" CACHE
15081508
STRING "Path to the CA bundle to embed in the curl tool.")
15091509

1510+
if(CURL_CA_FALLBACK AND NOT CURL_USE_OPENSSL)
1511+
message(FATAL_ERROR "CURL_CA_FALLBACK only works with OpenSSL.")
1512+
endif()
1513+
15101514
if(CURL_CA_BUNDLE STREQUAL "")
15111515
message(FATAL_ERROR "Invalid value of CURL_CA_BUNDLE. Use 'none', 'auto' or file path.")
15121516
elseif(CURL_CA_BUNDLE STREQUAL "none")

acinclude.m4

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,10 +1242,10 @@ AS_HELP_STRING([--without-ca-path], [Don't use a default CA path]),
12421242
AC_MSG_RESULT([no])
12431243
fi
12441244
1245-
AC_MSG_CHECKING([whether to use built-in CA store of SSL library])
1245+
AC_MSG_CHECKING([whether to use OpenSSL's built-in CA store])
12461246
AC_ARG_WITH(ca-fallback,
1247-
AS_HELP_STRING([--with-ca-fallback], [Use the built-in CA store of the SSL library])
1248-
AS_HELP_STRING([--without-ca-fallback], [Don't use the built-in CA store of the SSL library]),
1247+
AS_HELP_STRING([--with-ca-fallback], [Use OpenSSL's built-in CA store])
1248+
AS_HELP_STRING([--without-ca-fallback], [Don't use OpenSSL's built-in CA store]),
12491249
[
12501250
if test "x$with_ca_fallback" != "xyes" -a "x$with_ca_fallback" != "xno"; then
12511251
AC_MSG_ERROR([--with-ca-fallback only allows yes or no as parameter])
@@ -1254,10 +1254,10 @@ AS_HELP_STRING([--without-ca-fallback], [Don't use the built-in CA store of the
12541254
[ with_ca_fallback="no"])
12551255
AC_MSG_RESULT([$with_ca_fallback])
12561256
if test "x$with_ca_fallback" = "xyes"; then
1257-
if test "x$OPENSSL_ENABLED" != "x1" -a "x$GNUTLS_ENABLED" != "x1"; then
1258-
AC_MSG_ERROR([--with-ca-fallback only works with OpenSSL or GnuTLS])
1257+
if test "x$OPENSSL_ENABLED" != "x1"; then
1258+
AC_MSG_ERROR([--with-ca-fallback only works with OpenSSL])
12591259
fi
1260-
AC_DEFINE_UNQUOTED(CURL_CA_FALLBACK, 1, [define "1" to use built-in CA store of SSL library])
1260+
AC_DEFINE_UNQUOTED(CURL_CA_FALLBACK, 1, [define "1" to use OpenSSL's built-in CA store])
12611261
fi
12621262
])
12631263

docs/INSTALL-CMAKE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ target_link_libraries(my_target PRIVATE CURL::libcurl)
258258

259259
- `CURL_CA_BUNDLE`: Path to the CA bundle. Set `none` to disable or `auto` for auto-detection. Default: `auto`
260260
- `CURL_CA_EMBED`: Path to the CA bundle to embed in the curl tool. Default: (disabled)
261-
- `CURL_CA_FALLBACK`: Use built-in CA store of TLS backend. Default: `OFF`
261+
- `CURL_CA_FALLBACK`: Use built-in CA store of OpenSSL. Default: `OFF`
262262
- `CURL_CA_PATH`: Location of default CA path. Set `none` to disable or `auto` for auto-detection. Default: `auto`
263263
- `CURL_CA_SEARCH_SAFE`: Enable safe CA bundle search (within the curl tool directory) on Windows. Default: `OFF`
264264

docs/TODO

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@
158158
18.15 --retry should resume
159159
18.17 consider filename from the redirected URL with -O ?
160160
18.18 retry on network is unreachable
161-
18.19 expand ~/ in config files
162161
18.20 hostname sections in config files
163162
18.21 retry on the redirected-to URL
164163
18.23 Set the modification date on an uploaded file
@@ -1134,12 +1133,6 @@
11341133

11351134
https://github.com/curl/curl/issues/1603
11361135

1137-
18.19 expand ~/ in config files
1138-
1139-
For example .curlrc could benefit from being able to do this.
1140-
1141-
See https://github.com/curl/curl/issues/2317
1142-
11431136
18.20 hostname sections in config files
11441137

11451138
config files would be more powerful if they could set different

docs/cmdline-opts/_EXITCODES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ HTTP page not retrieved. The requested URL was not found or returned another
6161
error with the HTTP error code being 400 or above. This return code only
6262
appears if --fail is used.
6363
## 23
64-
Write error. curl could not write data to a local filesystem or similar.
64+
Write error. curl could not write data to a local file system or similar.
6565
## 25
6666
Failed starting the upload. For FTP, the server typically denied the STOR
6767
command.

docs/examples/block_ip.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ static curl_socket_t opensocket(void *clientp,
254254
struct connection_filter *filter = (struct connection_filter *)clientp;
255255
#ifdef AF_INET6
256256
int mapped = !filter->ipv6_v6only &&
257-
is_ipv4_mapped_ipv6_address(address->family, cinaddr);
257+
is_ipv4_mapped_ipv6_address(address->family, cinaddr);
258258
#endif
259259

260260
for(ip = filter->list; ip; ip = ip->next) {
@@ -281,7 +281,7 @@ static curl_socket_t opensocket(void *clientp,
281281
char buf[128] = {0};
282282
inet_ntop(address->family, cinaddr, buf, sizeof(buf));
283283
fprintf(stderr,
284-
"* Rejecting IP %s due to missing whitelist entry.\n", buf);
284+
"* Rejecting IP %s due to missing whitelist entry.\n", buf);
285285
}
286286
return CURL_SOCKET_BAD;
287287
}

docs/examples/http2-download.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
/* This little trick makes sure that we do not enable pipelining for libcurls
4343
old enough to not have this symbol. It is _not_ defined to zero in a recent
4444
libcurl header. */
45-
#define CURLPIPE_MULTIPLEX 0
45+
#define CURLPIPE_MULTIPLEX 0L
4646
#endif
4747

4848
struct transfer {

docs/examples/http2-upload.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
/* This little trick makes sure that we do not enable pipelining for libcurls
5656
old enough to not have this symbol. It is _not_ defined to zero in a recent
5757
libcurl header. */
58-
#define CURLPIPE_MULTIPLEX 0
58+
#define CURLPIPE_MULTIPLEX 0L
5959
#endif
6060

6161
#define NUM_HANDLES 1000

docs/examples/unixsocket.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#ifdef USE_ABSTRACT
3232
/*
3333
* The abstract socket namespace is a nonportable Linux extension. The name
34-
* has no connection with filesystem pathnames.
34+
* has no connection with file system pathnames.
3535
*/
3636
#define ABSTRACT "http-unix-domain"
3737
#else

0 commit comments

Comments
 (0)