fix: [BT-1616]: speed up graphql schema load time (#36218)

* fix: [BT-1616]: reduce the number of times we load the schema files from 3 to 2

* fix: [BT-1616]: take out unnecessary if null checks when in init

* fix: [BT-1616]: reformat and optimize imports

Author: Rick Marry

400-rest/src/main/java/software/wings/graphql/provider/GraphQLProvider.java

@@ -56,24 +56,15 @@ public class GraphQLProvider implements QueryLanguageProvider<GraphQL> {
 
   @Inject
   public void init() {
-    if (privateGraphQL == null) {
-      String[] allPaths = new String[] {GRAPHQL_SCHEMA_PRIVATE_DIRECTORY_PATH, GRAPHQL_SCHEMA_PUBLIC_DIRECTORY_PATH};
-      privateGraphQL = getGraphQL(allPaths);
-    }
-
-    if (publicGraphQL == null) {
-      String[] allPaths = new String[] {GRAPHQL_SCHEMA_PUBLIC_DIRECTORY_PATH};
-      publicGraphQL = getGraphQL(allPaths);
-    }
+    TypeDefinitionRegistry typeDefinitionRegistry = new TypeDefinitionRegistry();
+    publicGraphQL = getGraphQL(GRAPHQL_SCHEMA_PUBLIC_DIRECTORY_PATH, typeDefinitionRegistry);
+    privateGraphQL = getGraphQL(GRAPHQL_SCHEMA_PRIVATE_DIRECTORY_PATH, typeDefinitionRegistry);
   }
 
-  private GraphQL getGraphQL(String[] paths) {
+  private GraphQL getGraphQL(String path, TypeDefinitionRegistry typeDefinitionRegistry) {
     SchemaParser schemaParser = new SchemaParser();
-    TypeDefinitionRegistry typeDefinitionRegistry = new TypeDefinitionRegistry();
 
-    for (String path : paths) {
-      loadSchemaForEnv(path, typeDefinitionRegistry, schemaParser);
-    }
+    loadSchemaForEnv(path, typeDefinitionRegistry, schemaParser);
     RuntimeWiring runtimeWiring = buildRuntimeWiring();
 
     SchemaGenerator schemaGenerator = new SchemaGenerator();