main: initialize the keyboard from within the video module#127
Open
mardy wants to merge 1 commit intodevkitPro:ogc-sdl-2.28from
Open
main: initialize the keyboard from within the video module#127mardy wants to merge 1 commit intodevkitPro:ogc-sdl-2.28from
mardy wants to merge 1 commit intodevkitPro:ogc-sdl-2.28from
Conversation
The keyboard is being read from OGC_PumpEvents, which is part of the video subsystem. Therefore ensure that it's initialized in that subsystem, and not in SDL_main. This fixes a bug where an application not using our SDL main would access invalid memory areas due to the keyboard not being initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard is being read from OGC_PumpEvents, which is part of the video subsystem. Therefore ensure that it's initialized in that subsystem, and not in SDL_main.
This fixes a bug where an application not using our SDL main would access invalid memory areas due to the keyboard not being initialized.