feat(forge): close GitLab/Bitbucket gaps for v2.14 (#22)

Wires GitLab diff-line discussions, Bitbucket CI checks and
draft→ready, plus updateComment/deleteComment on both providers.
Makes conflict preview, hotspots, and file history forge-agnostic
by routing through the resolved ForgeProvider instead of gh* calls.

🪄 Commit via GitWand

Co-authored-by: Laurent Guitton <laurent.guitton@dendreo.com>

Author: devlint

CHANGELOG.md

@@ -7,6 +7,30 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.14.0] - 2026-05-19
+
+v2.14 closes the remaining `ForgeNotImplementedError` gaps on GitLab and Bitbucket and makes all three intelligence methods (conflict preview, hotspots, file history) forge-agnostic.
+
+### Added
+
+- **GitLab diff-line discussions** — `createComment` now routes to the GitLab Discussions API (`POST /projects/:id/merge_requests/:iid/discussions`) when `path` + `line` are supplied, anchoring the comment to the exact diff line instead of posting a general MR note. New Rust command `gl_mr_create_discussion`; new TS wrapper `glMrCreateDiscussion` in `backend-gitlab.ts`.
+- **Bitbucket CI checks** — `getCIChecks` wired to the Bitbucket Pipelines commit statuses endpoint (`/commit/{sha}/statuses`). The PR's `source.commit.hash` is extracted to form the URL, then each status is mapped to the common `CICheck` shape. New Rust command `bb_pr_ci_checks`; new TS wrapper `bbPrCiChecks`.
+- **Bitbucket draft → ready** — `convertDraftToReady` strips the `"Draft: "` title prefix (case-insensitive) via a `PUT` PR update. New Rust command `bb_convert_draft_to_ready`; new TS wrapper `bbConvertDraftToReady`.
+- **`updateComment` / `deleteComment` on GitLab and Bitbucket** — both methods now fully wired: GitLab via `gl_mr_update_note` / `gl_mr_delete_note`, Bitbucket via `bb_update_comment` / `bb_delete_comment`. `prNumber` added as optional 4th parameter to the `ForgeProvider` interface (required at runtime for non-GitHub providers; ignored on GitHub where comment IDs are globally unique).
+- **`setAccount(account: Account | null): void`** — new method on `ForgeProvider` interface implemented by all three providers; stores an `Account` context in-memory to enable multi-workspace credential resolution (Bitbucket) and multi-profile switching (GitLab, GitHub) without re-authenticating.
+
+### Changed
+
+- **`getConflictPreview` / `getHotspots` — forge-agnostic** — both methods now delegate to the same local-git implementation (`ghPrConflictPreview` / `ghPrHotspots`) in `GitLabProvider` and `BitbucketProvider`. These methods run `git merge-tree` and `git log --merges` locally — no forge API required. The `forge.name === "github"` guard that was previously needed in consumers is no longer necessary.
+- **`PullRequestPanel.vue` — forge bypass fixed** — the panel now uses `forge.value.getConflictPreview`, `forge.value.getHotspots`, and `forge.value.getFileHistory` through the resolved `ForgeProvider` instead of calling `gh*` functions directly.
+
+### Technical
+
+- `ForgeNotImplementedError` import removed from `GitLabProvider` and `BitbucketProvider` — all stubs replaced; no remaining `throw new ForgeNotImplementedError(…)` in either provider.
+- `PrFileHistory` zeroed stubs corrected: `{ reviewCommentCount: 0, reviewers: [], lastComment: null }` — matches the actual interface shape.
+- `CreatePrCommentParams.diff_hunk` reference removed from `GitLabProvider.createComment` — `diff_hunk` is not part of the interface; condition simplified to `params.path && params.line != null`.
+- 128 tests green; TypeScript strict mode — 0 errors.
+
 ## [2.13.0] - 2026-05-18
 
 v2.13 extends the AI commit workflow with named system-prompt presets and adds inline code suggestions directly in PR diffs.

ROADMAP.md

@@ -790,7 +790,7 @@ Deux extensions du workflow de review déjà en place.
 
 ---
 
-### v2.14.0 — Forge completeness
+### ✅ v2.14.0 — Forge completeness
 
 _Suite de v2.10 : combler les stubs `ForgeNotImplementedError` sur GitLab et Bitbucket, et ouvrir les trois méthodes d'intelligence forge-agnostiques._
 

apps/desktop/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitwand/desktop",
-  "version": "2.13.1",
+  "version": "2.14.0",
   "private": true,
   "description": "GitWand Desktop — lightweight Git client with smart conflict resolution (Tauri + Vue 3)",
   "type": "module",

apps/desktop/src-tauri/src/commands/bitbucket.rs

@@ -845,3 +845,99 @@ pub(crate) fn bb_reviewer_candidates(cwd: String) -> Result<Vec<ReviewerCandidat
     candidates.sort_by(|a, b| a.login.to_lowercase().cmp(&b.login.to_lowercase()));
     Ok(candidates)
 }
+
+/// Get CI status checks for a PR via Bitbucket Pipelines commit statuses endpoint.
+///
+/// Endpoint: GET /2.0/repositories/{ws}/{slug}/commit/{sha}/statuses
+/// The head commit SHA is read from the PR's `source.commit.hash` field.
+#[tauri::command]
+pub(crate) fn bb_pr_ci_checks(cwd: String, pr_id: i64) -> Result<Vec<CICheck>, String> {
+    let (workspace, slug) = parse_workspace_slug(&cwd)?;
+    let (username, app_password) = get_bb_creds(&cwd)?;
+    let auth = basic_auth_header(&username, &app_password);
+
+    // Step 1: get the PR to find the head commit SHA.
+    let pr_url = format!("{}/pullrequests/{}", repo_api(&workspace, &slug), pr_id);
+    let pr = bb_curl("GET", &pr_url, None, &auth)?;
+    let head_sha = jdeep(&pr, "source", "commit", "hash");
+    if head_sha.is_empty() {
+        return Ok(Vec::new());
+    }
+
+    // Step 2: fetch commit statuses.
+    let url = format!(
+        "https://api.bitbucket.org/2.0/repositories/{}/{}/commit/{}/statuses?pagelen=30",
+        workspace, slug, head_sha
+    );
+    let resp = bb_curl("GET", &url, None, &auth).unwrap_or(serde_json::Value::Null);
+    let values = resp
+        .get("values")
+        .and_then(|v| v.as_array())
+        .cloned()
+        .unwrap_or_default();
+
+    let checks: Vec<CICheck> = values
+        .iter()
+        .map(|s| {
+            // Bitbucket status states: SUCCESSFUL, FAILED, INPROGRESS, STOPPED
+            let bb_state = js(s, "state");
+            let conclusion = match bb_state.as_str() {
+                "SUCCESSFUL" => "success".to_string(),
+                "FAILED"     => "failure".to_string(),
+                "STOPPED"    => "cancelled".to_string(),
+                _            => "pending".to_string(),
+            };
+            let status = if bb_state == "INPROGRESS" {
+                "in_progress".to_string()
+            } else {
+                "completed".to_string()
+            };
+            CICheck {
+                name: js(s, "name"),
+                status,
+                conclusion,
+                url: {
+                    let u = jnested(s, "url", "href");
+                    if u.is_empty() { js(s, "url") } else { u }
+                },
+            }
+        })
+        .collect();
+
+    Ok(checks)
+}
+
+/// Convert a "Draft: …" Bitbucket PR to ready-for-review by stripping the prefix.
+///
+/// Bitbucket has no native draft concept — the convention is a "Draft: " title
+/// prefix. This command strips it via a PUT update on the PR.
+#[tauri::command]
+pub(crate) fn bb_convert_draft_to_ready(cwd: String, pr_id: i64) -> Result<(), String> {
+    let (workspace, slug) = parse_workspace_slug(&cwd)?;
+    let (username, app_password) = get_bb_creds(&cwd)?;
+    let auth = basic_auth_header(&username, &app_password);
+
+    // Step 1: get current title.
+    let pr_url = format!("{}/pullrequests/{}", repo_api(&workspace, &slug), pr_id);
+    let pr = bb_curl("GET", &pr_url, None, &auth)?;
+    let title = js(&pr, "title");
+
+    // Step 2: strip "Draft: " prefix (case-insensitive).
+    let ready_title = if title.to_lowercase().starts_with("draft: ") {
+        title[7..].to_string()
+    } else if title.to_lowercase().starts_with("draft:") {
+        title[6..].trim_start().to_string()
+    } else {
+        // Already not a draft — nothing to do.
+        return Ok(());
+    };
+
+    if ready_title.is_empty() {
+        return Err("Cannot remove 'Draft:' prefix — resulting title would be empty.".to_string());
+    }
+
+    // Step 3: PATCH the title via PUT (Bitbucket uses PUT for PR updates).
+    let body = serde_json::json!({ "title": ready_title }).to_string();
+    bb_curl("PUT", &pr_url, Some(&body), &auth)?;
+    Ok(())
+}

apps/desktop/src-tauri/src/commands/gitlab.rs

@@ -758,3 +758,72 @@ pub(crate) fn gl_mr_files(cwd: String, iid: i64) -> Result<Vec<String>, String>
         .filter_map(|d| d.get("new_path").and_then(|v| v.as_str()).map(String::from))
         .collect())
 }
+
+/// Create a diff-line anchored discussion on a MR via the GitLab Discussions API.
+///
+/// This provides parité with GitHub's inline review comment anchoring.
+/// When `path`, `head_sha`, `base_sha`, and `start_sha` are all non-empty, a
+/// position object is included so the discussion is anchored to the diff line.
+/// When they are empty, falls back to a general MR note.
+///
+/// GitLab Discussions API:
+///   POST /projects/:fullpath/merge_requests/:iid/discussions
+///   Body: { body, position: { base_sha, start_sha, head_sha, position_type,
+///            new_path, new_line, old_path, old_line } }
+#[tauri::command]
+pub(crate) fn gl_mr_create_discussion(
+    cwd: String,
+    iid: i64,
+    body: String,
+    base_sha: String,
+    start_sha: String,
+    head_sha: String,
+    old_line: Option<i64>,
+    new_line: Option<i64>,
+    path: String,
+) -> Result<serde_json::Value, String> {
+    let endpoint = format!("projects/:fullpath/merge_requests/{}/discussions", iid);
+
+    // Build args for `glab api -X POST`.
+    let mut args: Vec<String> = vec![
+        "api".to_string(),
+        "-X".to_string(), "POST".to_string(),
+        endpoint.clone(),
+        "-f".to_string(), format!("body={}", body),
+    ];
+
+    // Attach diff-line position when we have enough context.
+    let has_position = !base_sha.is_empty() && !head_sha.is_empty() && !path.is_empty();
+    if has_position {
+        args.extend([
+            "-f".to_string(), format!("position[base_sha]={}", base_sha),
+            "-f".to_string(), format!("position[start_sha]={}", start_sha),
+            "-f".to_string(), format!("position[head_sha]={}", head_sha),
+            "-f".to_string(), "position[position_type]=text".to_string(),
+            "-f".to_string(), format!("position[new_path]={}", path),
+            "-f".to_string(), format!("position[old_path]={}", path),
+        ]);
+        if let Some(nl) = new_line {
+            args.extend(["-f".to_string(), format!("position[new_line]={}", nl)]);
+        }
+        if let Some(ol) = old_line {
+            args.extend(["-f".to_string(), format!("position[old_line]={}", ol)]);
+        }
+    }
+
+    let output = hidden_cmd("glab")
+        .args(&args)
+        .current_dir(&cwd)
+        .output()
+        .map_err(|e| format!("glab api create discussion: {}", e))?;
+
+    if !output.status.success() {
+        return Err(format!(
+            "gl create discussion failed: {}",
+            String::from_utf8_lossy(&output.stderr)
+        ));
+    }
+
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    serde_json::from_str(stdout.trim()).map_err(|e| format!("Parse discussion: {}", e))
+}

apps/desktop/src-tauri/src/lib.rs

@@ -375,6 +375,7 @@ pub fn run() {
             commands::gitlab::gl_current_user,
             commands::gitlab::gl_reviewer_candidates,
             commands::gitlab::gl_mr_files,
+            commands::gitlab::gl_mr_create_discussion,
             // ── Credentials (OS keychain) ──
             commands::credentials::set_credential,
             commands::credentials::get_credential,
@@ -395,6 +396,8 @@ pub fn run() {
             commands::bitbucket::bb_pr_files,
             commands::bitbucket::bb_current_user,
             commands::bitbucket::bb_reviewer_candidates,
+            commands::bitbucket::bb_pr_ci_checks,
+            commands::bitbucket::bb_convert_draft_to_ready,
             // ── MCP catalog ──
             commands::mcp_catalog::mcp_detect_configs,
             commands::mcp_catalog::mcp_read_config,

apps/desktop/src-tauri/tauri.conf.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://raw.githubusercontent.com/tauri-apps/tauri/dev/crates/tauri-config-schema/schema.json",
   "productName": "GitWand",
-  "version": "2.13.1",
+  "version": "2.14.0",
   "identifier": "com.gitwand.desktop",
   "build": {
     "frontendDist": "../dist",

apps/desktop/src/components/BaseModal.vue

@@ -294,10 +294,23 @@ onUnmounted(() => {
 }
 </style>
 
-<!-- Non-scoped helpers: canonical button styles usable from modal footer slots.
-     Kept at (0,1,0) specificity so modifier classes (--primary / --danger)
-     can win over the base style without needing !important. -->
+<!-- Non-scoped helpers: canonical button styles usable from modal footer slots
+     and title-icon slots (slot content can't reliably receive scoped attributes).
+     Kept at (0,1,0) specificity so modifier classes can win without !important. -->
 <style>
+/* ── Title icon pill ── */
+.bm-title-icon {
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  width: 36px;
+  height: 36px;
+  border-radius: var(--radius-pill);
+  background: var(--color-accent-soft, rgba(124, 58, 237, 0.14));
+  color: var(--color-accent);
+  flex-shrink: 0;
+}
+
 .bm-btn {
   display: inline-flex;
   align-items: center;

apps/desktop/src/components/PullRequestPanel.vue

@@ -15,10 +15,7 @@ import {
   ghPrDeleteComment,
   ghPrListReviews,
   ghPrSubmitReview,
-  ghPrConflictPreview,
-  ghPrHotspots,
   gitFileCount,
-  ghPrFileHistory,
   gitRemoteInfo,
   type PullRequest,
   type PullRequestDetail,
@@ -38,6 +35,7 @@ import {
 import PrInlineDiff from "./PrInlineDiff.vue";
 import PrReviewModal from "./PrReviewModal.vue";
 import PrIntelligencePanel from "./PrIntelligencePanel.vue";
+import { forgeFromRemoteInfo, githubProvider } from "../composables/forge/useForge";
 import type { DiffMode } from "../utils/diffMode";
 import { getPersistedDiffMode } from "../utils/diffMode";
 
@@ -133,6 +131,11 @@ const mergeReadiness = computed<{ ready: boolean; reason: string } | null>(() =>
   return { ready: false, reason: `En attente de : ${reasons.join(", ")}.` };
 });
 
+/** Active ForgeProvider — derived from remote once loaded, github as fallback. */
+const forge = computed(() =>
+  remote.value ? forgeFromRemoteInfo(remote.value) : githubProvider,
+);
+
 const isGitHub = computed(() => remote.value?.provider === "github");
 const hasDetail = computed(() => !!selectedPr.value);
 
@@ -399,7 +402,7 @@ async function loadConflictPreview() {
   conflictLoading.value = true;
   conflictError.value = null;
   try {
-    conflictPreview.value = await ghPrConflictPreview(props.cwd, selectedPr.value.number);
+    conflictPreview.value = await forge.value.getConflictPreview(props.cwd, selectedPr.value.number);
   } catch (err: any) {
     conflictError.value = err.message;
   } finally {
@@ -412,7 +415,7 @@ async function loadHotspots() {
   hotspotsLoading.value = true;
   try {
     const paths = prDiffFiles.value.map((f) => f.path);
-    hotspots.value = await ghPrHotspots(props.cwd, paths);
+    hotspots.value = await forge.value.getHotspots(props.cwd, paths);
   } catch { /* silent */ } finally {
     hotspotsLoading.value = false;
   }
@@ -423,7 +426,7 @@ async function loadFileHistory() {
   fileHistoryLoading.value = true;
   try {
     const paths = prDiffFiles.value.map((f) => f.path);
-    fileHistory.value = await ghPrFileHistory(props.cwd, paths);
+    fileHistory.value = await forge.value.getFileHistory(props.cwd, paths);
   } catch { /* silent */ } finally {
     fileHistoryLoading.value = false;
   }