Simplify and harden scenario for file not found locally#62
Merged
Conversation
Rather than appending the Etag to the download provider only if force!=true, skip adding it too when the local file doesn't exist. It typically means we'll need to fully download and we were checking that separately after checking for not-modified, which duplicated some code. Also check for temp path before enumerating the first .cs, since sometimes the dir might not exist (download failed?) and we would fail with a cryptic IO exception.
Member
Author
|
🧪 Details on Ubuntu 24.04.4 LTSfrom retest v1.1.0 on .NET 10.0.7 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than appending the Etag to the download provider only if force!=true, skip adding it too when the local file doesn't exist. It typically means we'll need to fully download and we were checking that separately after checking for not-modified, which duplicated some code.
Also check for temp path before enumerating the first .cs, since sometimes the dir might not exist (download failed?) and we would fail with a cryptic IO exception.