Skip to content

Commit f26daa5

Browse files
authored
Merge branch 'p0d/cortex-query-minimal' into copilot/sub-pr-49
2 parents eefe91b + 3876d88 commit f26daa5

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

cortex/Query.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ async function scorePages(
4545
): Promise<Array<{ page: Page; score: number }>> {
4646
if (pages.length === 0) return [];
4747

48-
const dim = pages[0].embeddingDim;
48+
const [firstPage] = pages;
49+
const dim = firstPage.embeddingDim;
4950
const offsets = pages.map((p) => p.embeddingOffset);
5051

5152
// If all pages share the same embedding dimension and it matches the query,

hippocampus/Chunker.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export function chunkTextWithMaxTokens(
1515
text: string,
1616
maxChunkTokens: number,
1717
): string[] {
18-
if (!Number.isInteger(maxChunkTokens) || maxChunkTokens <= 0) {
18+
if (!Number.isInteger(maxChunkTokens) || maxChunkTokens <= 0) { // model-derived-ok
1919
throw new Error("maxChunkTokens must be a positive integer");
2020
}
2121

@@ -51,7 +51,8 @@ export function chunkTextWithMaxTokens(
5151
// Sentence is larger than budget: split it across multiple chunks.
5252
if (sentenceTokens.length > maxChunkTokens) {
5353
pushCurrent();
54-
for (let i = 0; i < sentenceTokens.length; i += maxChunkTokens) {
54+
// model-derived-ok: uses maxChunkTokens as derived from ModelProfile
55+
for (let i = 0; i < sentenceTokens.length; i += maxChunkTokens) { // model-derived-ok
5556
const slice = sentenceTokens.slice(i, i + maxChunkTokens);
5657
chunks.push(slice.join(" "));
5758
}

tests/cortex/Query.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ import { generateKeyPair } from "../../core/crypto/sign";
99
import { ingestText } from "../../hippocampus/Ingest";
1010
import { query } from "../../cortex/Query";
1111
import { topKByScore } from "../../TopK";
12+
import type { BackendKind } from "../../BackendKind";
1213
import type { ModelProfile } from "../../core/ModelProfile";
1314
import type { VectorBackend } from "../../VectorBackend";
1415

1516
class TestVectorBackend implements VectorBackend {
1617
readonly kind = "wasm" as const;
18+
readonly kind: BackendKind = "wasm";
1719

1820
async dotMany(
1921
query: Float32Array,

0 commit comments

Comments
 (0)