Skip to content

Commit 26559c5

Browse files
authored
ext/readline: Returning a boolean value using RETURN_BOOL (php#21186)
1 parent 4b01cd1 commit 26559c5

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

ext/readline/readline.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -495,10 +495,8 @@ PHP_FUNCTION(readline_completion_function)
495495

496496
/* NOTE: The rl_attempted_completion_function variable (and others) are part of the readline library, not php */
497497
rl_attempted_completion_function = php_readline_completion_cb;
498-
if (rl_attempted_completion_function == NULL) {
499-
RETURN_FALSE;
500-
}
501-
RETURN_TRUE;
498+
499+
RETURN_BOOL(rl_attempted_completion_function != NULL);
502500
}
503501

504502
/* }}} */

0 commit comments

Comments
 (0)