Skip to content

Commit c39437a

Browse files
authored
Merge pull request codex-team#293 from devnull-1337/fix/removed-home-page
Removed home page special permissions
2 parents d657711 + b1f56d4 commit c39437a

6 files changed

Lines changed: 14 additions & 13 deletions

File tree

src/application/i18n/messages/en.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
},
88
"header": {
99
"buttons": {
10-
"home": "Home",
1110
"noteSettings": "Settings"
1211
}
1312
},
@@ -176,7 +175,6 @@
176175
}
177176
},
178177
"pages": {
179-
"home": "Home",
180178
"note": "Note",
181179
"newNote": "New note",
182180
"landing": "landing",

src/application/services/useNavbar.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ interface useNavbarComposableState {
2929
patchOpenedPageByUrl: (url: OpenedPage['url'], page: OpenedPage) => void;
3030

3131
/**
32-
* Delete all opened pages excluding Home page
32+
* Delete all opened pages
3333
*/
3434
deleteOpenedPages: () => void;
3535

@@ -77,7 +77,7 @@ export default function useNavbar(): useNavbarComposableState {
7777
};
7878

7979
/**
80-
* Delete all opened pages excluding Home page
80+
* Delete all opened pages
8181
*/
8282
function deleteOpenedPages(): void {
8383
workspaceService.deleteOpenedPages();
@@ -94,8 +94,13 @@ export default function useNavbar(): useNavbarComposableState {
9494
deleteOpenedPageByUrl(route.path);
9595
}
9696

97-
addOpenedPage({ title: t(currentRoute.meta.pageTitleI18n),
98-
url: currentRoute.path });
97+
/**
98+
* If the route is '/' do not add the page
99+
*/
100+
if (currentRoute.path !== '/') {
101+
addOpenedPage({ title: t(currentRoute.meta.pageTitleI18n),
102+
url: currentRoute.path });
103+
}
99104
});
100105

101106
/**

src/domain/workspace.repository.interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default interface WorkspaceRepositoryInterface {
2222
patchOpenedPageByUrl: (url: OpenedPage['url'], page: OpenedPage) => void;
2323

2424
/**
25-
* Delete all opened pages excluding Home page
25+
* Delete all opened pages
2626
*/
2727
deleteOpenedPages: () => void;
2828

src/infrastructure/storage/openedPage.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,11 @@ export class OpenedPagesStore extends PersistantStore<OpenedPagesStoreData> {
6363
}
6464

6565
/**
66-
* Delete all opened pages excluding Home page
66+
* Delete all opened pages
6767
*/
6868
public deleteOpenedPages(): void {
6969
this.data.openedPages?.forEach((currentPage) => {
70-
if (currentPage.url !== '/') {
71-
this.deleteOpenedPageByUrl(currentPage.url);
72-
}
70+
this.deleteOpenedPageByUrl(currentPage.url);
7371
});
7472
}
7573
}

src/infrastructure/workspace.repository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default class WorkspaceRepository extends Repository<OpenedPagesStore, Op
3939
}
4040

4141
/**
42-
* Delete all opened pages excluding Home page
42+
* Delete all opened pages
4343
*/
4444
public deleteOpenedPages(): void {
4545
this.store.deleteOpenedPages();

src/presentation/components/app-navbar/AppNavbar.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const tabs = computed(() => currentOpenedPages.value.map((page): TabParams => {
4747
return {
4848
id: page.url,
4949
title: page.title,
50-
closable: page.title !== 'Home',
50+
closable: true,
5151
isActive: page.url === route.path,
5252
};
5353
}));

0 commit comments

Comments
 (0)