-
Notifications
You must be signed in to change notification settings - Fork 44
Expand file tree
/
Copy pathWebAuthnManagementAPITest.java
More file actions
237 lines (195 loc) · 8.16 KB
/
Copy pathWebAuthnManagementAPITest.java
File metadata and controls
237 lines (195 loc) · 8.16 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
package com.digitalsanctuary.spring.user.api;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.time.Instant;
import java.util.Collections;
import java.util.List;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.security.core.userdetails.UserDetails;
import com.digitalsanctuary.spring.user.dto.WebAuthnCredentialInfo;
import com.digitalsanctuary.spring.user.exceptions.WebAuthnException;
import com.digitalsanctuary.spring.user.exceptions.WebAuthnUserNotFoundException;
import com.digitalsanctuary.spring.user.persistence.model.User;
import com.digitalsanctuary.spring.user.service.UserService;
import com.digitalsanctuary.spring.user.service.WebAuthnCredentialManagementService;
import com.digitalsanctuary.spring.user.test.annotations.ServiceTest;
import com.digitalsanctuary.spring.user.test.fixtures.TestFixtures;
import com.digitalsanctuary.spring.user.util.GenericResponse;
@ServiceTest
@DisplayName("WebAuthnManagementAPI Tests")
class WebAuthnManagementAPITest {
@Mock
private WebAuthnCredentialManagementService credentialManagementService;
@Mock
private UserService userService;
@Mock
private UserDetails userDetails;
@InjectMocks
private WebAuthnManagementAPI api;
private User testUser;
@BeforeEach
void setUp() {
testUser = TestFixtures.Users.standardUser();
when(userDetails.getUsername()).thenReturn(testUser.getEmail());
when(userService.findUserByEmail(testUser.getEmail())).thenReturn(testUser);
}
@Nested
@DisplayName("GET /user/webauthn/credentials")
class GetCredentialsTests {
@Test
@DisplayName("should return credentials for authenticated user")
void shouldReturnCredentials() {
// Given
WebAuthnCredentialInfo cred = WebAuthnCredentialInfo.builder().id("cred-1").label("My iPhone").created(Instant.now())
.build();
when(credentialManagementService.getUserCredentials(testUser)).thenReturn(List.of(cred));
// When
ResponseEntity<List<WebAuthnCredentialInfo>> response = api.getCredentials(userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody()).hasSize(1);
assertThat(response.getBody().get(0).getLabel()).isEqualTo("My iPhone");
}
@Test
@DisplayName("should return empty list when no credentials")
void shouldReturnEmptyList() {
// Given
when(credentialManagementService.getUserCredentials(testUser)).thenReturn(Collections.emptyList());
// When
ResponseEntity<List<WebAuthnCredentialInfo>> response = api.getCredentials(userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody()).isEmpty();
}
@Test
@DisplayName("should throw not found when user not found")
void shouldThrowNotFoundWhenUserNotFound() {
// Given
when(userService.findUserByEmail(testUser.getEmail())).thenReturn(null);
// When
assertThatThrownBy(() -> api.getCredentials(userDetails)).isInstanceOf(WebAuthnUserNotFoundException.class)
.hasMessageContaining("User not found");
}
}
@Nested
@DisplayName("GET /user/webauthn/has-credentials")
class HasCredentialsTests {
@Test
@DisplayName("should return true when user has credentials")
void shouldReturnTrue() {
// Given
when(credentialManagementService.hasCredentials(testUser)).thenReturn(true);
// When
ResponseEntity<Boolean> response = api.hasCredentials(userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody()).isTrue();
}
@Test
@DisplayName("should return false when user has no credentials")
void shouldReturnFalse() {
// Given
when(credentialManagementService.hasCredentials(testUser)).thenReturn(false);
// When
ResponseEntity<Boolean> response = api.hasCredentials(userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody()).isFalse();
}
@Test
@DisplayName("should throw not found when user not found")
void shouldThrowNotFoundWhenUserNotFound() {
// Given
when(userService.findUserByEmail(testUser.getEmail())).thenReturn(null);
// When
assertThatThrownBy(() -> api.hasCredentials(userDetails)).isInstanceOf(WebAuthnUserNotFoundException.class)
.hasMessageContaining("User not found");
verify(credentialManagementService, never()).hasCredentials(any());
}
}
@Nested
@DisplayName("PUT /user/webauthn/credentials/{id}/label")
class RenameCredentialTests {
@Test
@DisplayName("should rename credential successfully")
void shouldRenameSuccessfully() {
// Given
WebAuthnManagementAPI.RenameCredentialRequest request = new WebAuthnManagementAPI.RenameCredentialRequest("Work Laptop");
// When
ResponseEntity<GenericResponse> response = api.renameCredential("cred-1", request, userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody().getMessage()).contains("renamed successfully");
verify(credentialManagementService).renameCredential("cred-1", "Work Laptop", testUser);
}
@Test
@DisplayName("should throw when rename fails")
void shouldThrowOnFailure() {
// Given
WebAuthnManagementAPI.RenameCredentialRequest request = new WebAuthnManagementAPI.RenameCredentialRequest("New Name");
doThrow(new WebAuthnException("Credential not found or access denied")).when(credentialManagementService)
.renameCredential(eq("cred-999"), eq("New Name"), any(User.class));
// When
assertThatThrownBy(() -> api.renameCredential("cred-999", request, userDetails)).isInstanceOf(WebAuthnException.class)
.hasMessageContaining("not found");
}
@Test
@DisplayName("should throw not found when user not found")
void shouldThrowNotFoundWhenUserNotFound() {
// Given
WebAuthnManagementAPI.RenameCredentialRequest request = new WebAuthnManagementAPI.RenameCredentialRequest("New Name");
when(userService.findUserByEmail(testUser.getEmail())).thenReturn(null);
// When
assertThatThrownBy(() -> api.renameCredential("cred-1", request, userDetails))
.isInstanceOf(WebAuthnUserNotFoundException.class).hasMessageContaining("User not found");
verify(credentialManagementService, never()).renameCredential(any(), any(), any());
}
}
@Nested
@DisplayName("DELETE /user/webauthn/credentials/{id}")
class DeleteCredentialTests {
@Test
@DisplayName("should delete credential successfully")
void shouldDeleteSuccessfully() {
// When
ResponseEntity<GenericResponse> response = api.deleteCredential("cred-1", userDetails);
// Then
assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(response.getBody().getMessage()).contains("deleted successfully");
verify(credentialManagementService).deleteCredential("cred-1", testUser);
}
@Test
@DisplayName("should throw when delete fails")
void shouldThrowOnFailure() {
// Given
doThrow(new WebAuthnException("Cannot delete last passkey")).when(credentialManagementService).deleteCredential(eq("cred-1"),
any(User.class));
// When
assertThatThrownBy(() -> api.deleteCredential("cred-1", userDetails)).isInstanceOf(WebAuthnException.class)
.hasMessageContaining("Cannot delete last passkey");
}
@Test
@DisplayName("should throw not found when user not found")
void shouldThrowNotFoundWhenUserNotFound() {
// Given
when(userService.findUserByEmail(testUser.getEmail())).thenReturn(null);
// When
assertThatThrownBy(() -> api.deleteCredential("cred-1", userDetails))
.isInstanceOf(WebAuthnUserNotFoundException.class).hasMessageContaining("User not found");
verify(credentialManagementService, never()).deleteCredential(any(), any());
}
}
}