test: stop global spring.profiles.active pollution that flaked RegistrationGuard wiring tests

BaseTestConfiguration set spring.profiles.active=test via System.setProperty,
a JVM-global mutation that leaked across the parallel test suite. When it raced
ahead of RegistrationGuardConfigurationTest — which runs an ApplicationContextRunner
with no profile and gates its consumer-guard configs on @Profile("!test") — the
test profile suppressed those guards, so DefaultRegistrationGuard was registered
and two wiring assertions failed (intermittently; surfaced on the Java 25 run).

The property was redundant: every test annotation and direct consumer already
declares @activeprofiles("test"), and ddl-auto/datasource are set in the test
properties files. Removed the TestPropertySourcesConfigurer entirely.

Also pinned RegistrationGuardConfigurationTest's runner to a non-test profile via
withPropertyValues so it stays deterministic against any future ambient leak.

Author: devondragon

src/test/java/com/digitalsanctuary/spring/user/registration/RegistrationGuardConfigurationTest.java

@@ -32,7 +32,14 @@ class RegistrationGuardConfigurationTest {
     // Register RegistrationGuardConfiguration as an auto-configuration so its @ConditionalOnMissingBean
     // evaluates AFTER any consumer-supplied guard beans — mirroring production, where this configuration
     // is component-scanned by the UserConfiguration auto-configuration (loaded after consumer beans).
+    //
+    // The inlined "spring.profiles.active" pins this context to a non-"test" profile so the @Profile("!test")
+    // guard configs below always load. Without it, the test depends on no "test" profile being active — a
+    // fragile assumption, because anything that sets the global "spring.profiles.active=test" system property
+    // (e.g. another test running concurrently) would suppress the guard configs and flake these assertions.
+    // The inlined property source outranks any leaked system property, making this deterministic.
     private final ApplicationContextRunner runner = new ApplicationContextRunner()
+            .withPropertyValues("spring.profiles.active=registrationguardtest")
             .withConfiguration(AutoConfigurations.of(RegistrationGuardConfiguration.class));
 
     @Test

src/test/java/com/digitalsanctuary/spring/user/test/config/BaseTestConfiguration.java

@@ -83,24 +83,4 @@ public Locale testLocale() {
         return Locale.US;
     }
 
-    /**
-     * Test-specific property overrides.
-     */
-    @Bean
-    public TestPropertySourcesConfigurer testPropertySourcesConfigurer() {
-        return new TestPropertySourcesConfigurer();
-    }
-
-    /**
-     * Helper class to configure test properties programmatically.
-     */
-    public static class TestPropertySourcesConfigurer {
-        
-        public TestPropertySourcesConfigurer() {
-            // Set system properties for tests
-            System.setProperty("spring.profiles.active", "test");
-            System.setProperty("spring.jpa.hibernate.ddl-auto", "create-drop");
-            System.setProperty("spring.datasource.initialization-mode", "always");
-        }
-    }
 }