fix: Replace hashCode with sequential counters in test builders

Address Copilot PR feedback to fix potential ID collision issues:
- UserTestDataBuilder: Use roleIdCounter instead of roleName.hashCode()
- RoleTestDataBuilder: Use privilegeIdCounter instead of privilegeName.hashCode()
- Added separate counters starting at different ranges to avoid conflicts
  - roleIdCounter starts at 1000L
  - privilegeIdCounter starts at 2000L

This prevents potential test flakiness from hashCode collisions
and provides more predictable test data generation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: devondragon

src/test/java/com/digitalsanctuary/spring/user/test/builders/RoleTestDataBuilder.java

@@ -24,6 +24,7 @@
 public class RoleTestDataBuilder {
 
     private static long idCounter = 1L;
+    private static long privilegeIdCounter = 2000L;
 
     private Long id;
     private String name;
@@ -116,7 +117,7 @@ public RoleTestDataBuilder withUsers(Set<User> users) {
 
     public RoleTestDataBuilder withPrivilege(String privilegeName) {
         Privilege privilege = new Privilege();
-        privilege.setId((long) privilegeName.hashCode());
+        privilege.setId(privilegeIdCounter++);
         privilege.setName(privilegeName);
         this.privileges.add(privilege);
         return this;

src/test/java/com/digitalsanctuary/spring/user/test/builders/UserTestDataBuilder.java

@@ -26,6 +26,7 @@ public class UserTestDataBuilder {
 
     private static final PasswordEncoder PASSWORD_ENCODER = new BCryptPasswordEncoder(4);
     private static long idCounter = 1L;
+    private static long roleIdCounter = 1000L;
 
     private Long id;
     private String firstName = "Test";
@@ -204,7 +205,7 @@ public UserTestDataBuilder withLockedDate(Date lockedDate) {
 
     public UserTestDataBuilder withRole(String roleName) {
         Role role = new Role();
-        role.setId((long) roleName.hashCode());
+        role.setId(roleIdCounter++);
         role.setName(roleName);
         this.roles.add(role);
         return this;