You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#611: handle missing upstream in settings update check
- detect missing upstream configuration for settings repository branch
- avoid executing 'rev-parse @{u}' when no upstream is configured
- prevent misleading git error logs for local-only branches
- provide clear warning message to inform the user about incorrect branch setup
StringlocalFailureMessage = String.format("Failed to get the local commit id of settings repository '%s'.", repository);
64
67
StringremoteFailureMessage = String.format("Failed to get the remote commit id of settings repository '%s', missing remote upstream branch?", repository);
@@ -78,7 +81,9 @@ public boolean isRepositoryUpdateAvailable(Path repository, Path trackedCommitId
78
81
LOG.warn("Commit ID was not present at {}", trackedCommitIdPath);
79
82
returntrue;
80
83
}
81
-
84
+
if (!hasUpstream(repository)) {
85
+
returnfalse;
86
+
}
82
87
StringremoteFailureMessage = String.format("Failed to get the remote commit id of settings repository '%s', missing remote upstream branch?", repository);
0 commit comments