Task summary
PR #2061 was merged with some minor review comments that were not implemented in the PR as the author is not available any more.
This story is about creating a new PR with the cleanups from the review of PR #2061.
All 3 review remarks were about the completion (mostly because not mvnd specific so they should be moved up to super-class and some considerations to question some of the completions).
Additional context
See my comments from final review of PR #2061.
Also it would be great to already add a method AutoCompletionRegistry.add(String candidate, String synonym) that so far only adds both arguments and then already group -T and --threads as well as others (e.g. -s and --settings) together in one call.
Later in another story we can improve the AutoCompletionRegistry so we can allow dependencies between completions and understand synonyms so if -s is already present, we do not need to suggest --settings any more.
For the record: IDEasy will automatically use -s and -Dsettings.security=... internally to make things work. Overriding this in ide mvn calls is quite of pointless and therefore also auto-completion for it but whatever...
Task summary
PR #2061 was merged with some minor review comments that were not implemented in the PR as the author is not available any more.
This story is about creating a new PR with the cleanups from the review of PR #2061.
All 3 review remarks were about the completion (mostly because not
mvndspecific so they should be moved up to super-class and some considerations to question some of the completions).Additional context
See my comments from final review of PR #2061.
Also it would be great to already add a method
AutoCompletionRegistry.add(String candidate, String synonym)that so far only adds both arguments and then already group-Tand--threadsas well as others (e.g.-sand--settings) together in one call.Later in another story we can improve the
AutoCompletionRegistryso we can allow dependencies between completions and understand synonyms so if-sis already present, we do not need to suggest--settingsany more.For the record: IDEasy will automatically use
-sand-Dsettings.security=...internally to make things work. Overriding this inide mvncalls is quite of pointless and therefore also auto-completion for it but whatever...