#865: az mac install#1945
Conversation
Coverage Report for CI Build 26284349856Warning No base build found for commit Coverage: 71.093%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
|
The fix needs changes in 3 repos:
Microsoft's Mac tarball needs Python 3.13 exactly it ships pre-compiled binaries built for that version, they won't load with 3.14. With the current default
Before proposing the default change I checked: So 3.13 as default looks like the simplest fix that makes Verified locally on Mac arm64: |
| OperatingSystem.WINDOWS); | ||
| VersionIdentifier vid = urlVersion.getVersionIdentifier(); | ||
| if (vid.compareVersion(MIN_AZURE_MAC_VID).isGreater()) { | ||
| String macBaseUrl = GITHUB_BASE_URL + "/" + getGithubRepositoryPath() |
There was a problem hiding this comment.
interesting: So here we actually have two different downloadBaseUrls.
That is new and we wont mock this then.
In JUnit we change getDownloadBaseUrl() to point to mockito.
Isn't AzureUrlUpdaterTest now dependent on the Internet with your change included?
So does that test then fail if you unplug the network and get offline?
There was a problem hiding this comment.
If I see this correctly, they changed their strategy and starting with 2.86.0 they publish releases via GitHub:
https://github.com/Azure/azure-cli/releases/tag/azure-cli-2.86.0
If that is correct, we might want to create a new UrlUpdater for azure based on GitHub releases.
We should discuss if we first merge this and let it run or if we add the outcome manually via PR to ide-urls and then simply replace the existing AzureUrlUpdater for the new implementation strategy...
There was a problem hiding this comment.
thanks for spotting the offline issue, fixed in the latest commit:
- Added getMacDownloadBaseUrl() so the mac URL can be overridden.
- AzureUrlUpdaterMock now points it at WireMock.
- Added a WireMock stub for the mac tarball URLs.
- Added tag 2.85.0 in azure-cli-tags.json so the mac branch actually runs in the
test.
test is fully offline now.
about moving to GitHub releases: agree, thats cleaner. Id prefer to keep this pr
small to fix #865, and open a follow-up issue for the rewrite. Happy to take that one
too.
…Boy1/IDEasy into feature/865-az-mac-install
This PR fixes #865
Implemented changes:
AzureUrlUpdaternow registers macOSarm64andx86_64tarballs published by Microsoft on GitHub releases starting at azure-cli 2.85.0.Azurecommandlet sets theAZ_PYTHONenvironment variable on macOS, pointing to IDEasy's installed Python. Required by Microsoft's tarball launcher script.CHANGELOG.adocentry under2026.05.001.Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal