#854: Fix Rancher Desktop path#2085
Open
laert-ll wants to merge 4 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 29005438306Coverage decreased (-0.08%) to 72.104%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions54 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
d1d4a3e to
4d139f6
Compare
4d139f6 to
5c91172
Compare
ed23f9c to
3f8d714
Compare
Contributor
Author
|
Thank you for testing this @oanding-blrng and raising the virtualization issue with WSL! After some discussion, we came to the conclusion that it's currently not possible to launch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #854
Implemented changes:
~/.rd/bin.Clarification: Rancher Desktop creates
~/.rd/binand links its CLI tools (docker, kubectl, rdctl) there only after its first GUI launch. Therefore in order to launch docker or kubectl using IDEasy, we added a warning message for when the user tries to launch it without having launched the GUI first.Testing instructions
ide kubectland verify that the installation is successful that the warning appears.ide kubectlagain and verify that it runs successfully.docker.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal