Skip to content

Commit e2462ab

Browse files
committed
Revert "Set cell in ExcelWriter to blank if the contents is empty after replacing placeholders. (#362)"
This reverts commit 5bf52d2. Revert was done as the change lead to some regressions in the created xls reports
1 parent 5bf52d2 commit e2462ab

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

core/src/main/java/com/devonfw/tools/solicitor/writer/xls/ExcelWriter.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,7 @@ private void iterateFromCell(Workbook wb, Cell cell, DataTable dataTable, String
339339
}
340340
}
341341
if (cellType == CellType.STRING) {
342-
if (text.isBlank()) {
343-
oneCell.setBlank();
344-
} else {
345-
oneCell.setCellValue(trimToMaxCellLength(text.replace("\r", "")));
346-
}
342+
oneCell.setCellValue(trimToMaxCellLength(text.replace("\r", "")));
347343
if (hasChanged) {
348344
addCommentToCell(oneCell, trimToMaxCellLength("Previous value: '" + oldModelText.replace("\r", "") + "'"));
349345
}

documentation/master-solicitor.asciidoc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,6 @@ _Solicitor_ if the includeFilter regex is matched and the excludeFilter regex is
416416
If the PackageURL of the component is not defined it will be represented as an empty string when doing the regular expression
417417
matching. (An empty/zero length regex string will match in this case.)
418418

419-
[[FromPackageURL,Deriving groupId, ArtifactId and Version from the PackageURL]]
420419
===== Deriving groupId, ArtifactId and Version from the PackageURL
421420

422421
If the data of components which is read via a Reader contains the coordinates groupId, artifactId and version as well as a PackageURL it might be possible that the mapping between the "coordinates" (which historically were initially defined for maven packages) and the PackageURL is not consistent to the standard mapping as used by Solicitor. By setting reader configuration property `deriveCoordinatesFromPurl` to `true` it is possible
@@ -2098,8 +2097,7 @@ creating a rule template file, defining the decision table as XLS or CSV file an
20982097
[appendix]
20992098
== Release Notes
21002099
Changes in 1.49.0::
2101-
* https://github.com/devonfw/solicitor/issues/360: Allow alignment of groupId, artifactId and version to PackageURL when reading component lists with Readers. See <<FromPackageURL>>.
2102-
* https://github.com/devonfw/solicitor/pull/362: Set cell in ExcelWriter to blank if the contents is empty after replacing placeholders.
2100+
* https://github.com/devonfw/solicitor/issues/360: Allow alignment of groupId, artifactId and version to PackageURL when reading component lists with Readers. See <<Deriving groupId, ArtifactId and Version from the PackageURL>>.
21032101

21042102
Changes in 1.48.0::
21052103
* https://github.com/devonfw/solicitor/pull/357: Refactor model import logic.

0 commit comments

Comments
 (0)