Skip to content

Improve Windows support#16

Open
bzoz wants to merge 1 commit into
devongovett:masterfrom
JaneaSystems:bartek-glob-args
Open

Improve Windows support#16
bzoz wants to merge 1 commit into
devongovett:masterfrom
JaneaSystems:bartek-glob-args

Conversation

@bzoz

@bzoz bzoz commented Jun 27, 2018

Copy link
Copy Markdown

This PR adds arguments globing, and makes the test run on Windows.

Currently qunit-cli does not support globing. This is however, how it is used in the wild, like in underscore:

"test-node": "qunit-cli test/*.js",

underscore (and some other packages that use qunit-cli) are used by Node.js to test new releases (see CITGM). Because globing does not work, those are currently skipped on Windows.

Adds arguments globing, and makes test run on Windows.
@piranna

piranna commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

Are you interested in maintain the project?

@bzoz

bzoz commented Jun 27, 2018

Copy link
Copy Markdown
Author

I'm mostly interested in making CITGM (so also qunit-cli) running well on Windows. I can't commit to maintaining the project all-around, but I'll be happy to help out with Windows issues.

@piranna

piranna commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

I'm not using qunit-cli anymore and moved to jest. If you want to be the project maintainer, it's free for you.

@bzoz

bzoz commented Jun 28, 2018

Copy link
Copy Markdown
Author

Ok then, at least I can fix the Windows issues.

@piranna

piranna commented Jun 28, 2018

Copy link
Copy Markdown
Contributor

Go for it :-)

@jdalton

jdalton commented Aug 17, 2018

Copy link
Copy Markdown

Hi @piranna!

I maintain a related project qunit-extras. I wouldn't mind helping qunit-cli put up deprecated notice in its readme/package to point folks to the now builtin-cli of qunit proper.

@piranna

piranna commented Aug 18, 2018

Copy link
Copy Markdown
Contributor

Do you have some references for that CLI?

@jdalton

jdalton commented Aug 19, 2018

Copy link
Copy Markdown

CLI support was added to QUnit in v2.3.0.
It's hard to link to in HTML because it's just in a note on Node support without an anchor.

@piranna

piranna commented Aug 19, 2018

Copy link
Copy Markdown
Contributor

That's nice :-) Ok, maybe we coudl deprecate this one, then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants