Skip to content

Commit 140368d

Browse files
Fixed lint and script defaults for dockerized tasks
1 parent c3a3643 commit 140368d

3 files changed

Lines changed: 8 additions & 15 deletions

File tree

.github/dependabot.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ updates:
1616
labels:
1717
- automatic
1818

19+
1920
# Enable version updates for pip
2021
- package-ecosystem: "pip"
2122
directory: "/"
@@ -24,4 +25,4 @@ updates:
2425
assignees:
2526
- "ChristophShyper"
2627
labels:
27-
- automatic
28+
- automatic

Taskfile.cicd.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,7 @@ tasks:
6161
lint:shellcheck:
6262
desc: Lint shell scripts with shellcheck
6363
cmds:
64-
- |
65-
echo "▶️ Running shellcheck..."
66-
set +e
67-
docker run --rm -i -v "$PWD:/work" -w /work koalaman/shellcheck:stable -x -S style entrypoint.sh
68-
rc=$?
69-
set -e
70-
if [ "$rc" -eq 0 ]; then
71-
echo "✅ shellcheck passed"
72-
else
73-
echo "❌ shellcheck failed"
74-
exit $rc
75-
fi
64+
- task: scripts:lint:shellcheck
7665

7766
lint:yamllint:
7867
desc: Lint YAML files with yamllint

Taskfile.scripts.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ tasks:
7979
desc: Get pull request template
8080
cmds:
8181
- mkdir -p .tmp
82-
- curl -LsS https://raw.githubusercontent.com/devops-infra/.github/master/PULL_REQUEST_TEMPLATE.md -o .tmp/PULL_REQUEST_TEMPLATE.md
82+
- curl -LsS https://raw.githubusercontent.com/devops-infra/.github/refs/tags/v1/PULL_REQUEST_TEMPLATE.md -o .tmp/PULL_REQUEST_TEMPLATE.md
8383

8484
git:set-config:
8585
desc: Set git user config
@@ -100,6 +100,10 @@ tasks:
100100
echo "❌ ERROR: VERSION is empty"
101101
exit 1
102102
fi
103+
if ! echo "{{.VERSION}}" | grep -Eq '^v?[0-9]+\.[0-9]+\.[0-9]+$'; then
104+
echo "❌ ERROR: VERSION '{{.VERSION}}' is not a valid semantic version (expected vX.Y.Z or X.Y.Z)"
105+
exit 1
106+
fi
103107
version:update:patch:
104108
desc: Increment patch version (e.g., 1.2.3 -> 1.2.4)
105109
cmds:
@@ -186,4 +190,3 @@ tasks:
186190
echo "ℹ️ INFO: Major tag '$MAJOR' already up-to-date"
187191
fi
188192
fi
189-

0 commit comments

Comments
 (0)