fix: limit SARIF rule tags to 10 for GitHub Code Scanning AB#2142#53
Merged
emmanuelknafo merged 1 commit intomainfrom Mar 30, 2026
Merged
fix: limit SARIF rule tags to 10 for GitHub Code Scanning AB#2142#53emmanuelknafo merged 1 commit intomainfrom
emmanuelknafo merged 1 commit intomainfrom
Conversation
- add truncateTags helper that prioritizes WCAG tags - apply to rule properties.tags in SARIF generator 🔧 - Generated by Copilot
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub Code Scanning warns that rules
image-altandselect-nameexceed the 10-tag limit in uploaded SARIF files. axe-core attaches many tags to rules (WCAG criteria, categories, best-practice markers), which can exceed GitHub's limit.Changes
truncateTags(tags, limit)helper that prioritizes WCAG tags (/^wcag\d/) then takes the first 10properties.tagswhen building SARIF rulesAll 28 existing SARIF tests pass.
Fixes AB#2142