[SITE] change to using resize to avoid logo cut#15058
Merged
toshywoshy merged 3 commits intodevopsdays:mainfrom Apr 15, 2025
Merged
[SITE] change to using resize to avoid logo cut#15058toshywoshy merged 3 commits intodevopsdays:mainfrom
toshywoshy merged 3 commits intodevopsdays:mainfrom
Conversation
see london logo on the main page it gets cut off using resize it should resize the image better and avoid any cutting off Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
✅ Deploy Preview for devopsdays-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattstratton
approved these changes
Apr 15, 2025
Member
mattstratton
left a comment
mattstratton
left a comment
There was a problem hiding this comment.
I think this is fine. There might be some weirdness for logos being squished but I think the code allows for a separate logo for the shortcode (for use on welcome page) than for the main screen as an override
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see London, Halifax and Istanbul logo on the main page it gets cut off
using resize it should resize the image better
and avoid any cutting off
For ease of understanding adding before and after screenshots
Before/Current : using the fill
After/Improvement : using resize