Skip to content

Feature/dimension group issue and unnested view issue#7

Merged
edgardevo merged 4 commits into
mainfrom
feature/dimension_group_issue_and_unnested_view_issue
Apr 3, 2026
Merged

Feature/dimension group issue and unnested view issue#7
edgardevo merged 4 commits into
mainfrom
feature/dimension_group_issue_and_unnested_view_issue

Conversation

@laurensvancraen

@laurensvancraen laurensvancraen commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Description

  1. Nullable Records: Dimensions in top-level nullable records now correctly include their parent path (e.g., ${TABLE}.product.created).
  2. Unnested Views: Nested fields within unnested views now use relative paths, avoiding incorrect parent array prefixing (e.g., ${TABLE}.item_meta.id instead of ${TABLE}.order_items.item_meta.id).

I've also added and verified regression tests:

  • src/tests/test_dimension_group_issue.py
  • src/tests/test_unnested_view_nested_fields.py

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added two test cases which firstly resulted in failed tests, afterwards i solved the bug and the test succeeded.

  • I ran pytest and all tests pass
  • I added new tests for my changes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (I have run ruff check . and ruff format .)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

)


if __name__ == "__main__":

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove name = "main" check.

see the other tests for reference

@edgardevo edgardevo merged commit 66e958c into main Apr 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants