Conversation
…se management and changelogs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes
vendor/lame/<platform>-<arch>/. Pipelines must permit the download step or configureLAME_BINARY,LAME_SKIP_DOWNLOAD, orLAME_FORCE_DOWNLOADto control it (more details seeREADME.md).exports. CommonJS imports are still supported. Deep imports likerequire("node-lame/lib/...")are no longer supported.Features
createLameEncoderStream/createLameDecoderStream) so audio can flow through stdin/stdout while progress events continue to fire (#11).Lame#setBufferacceptsArrayBufferand all typed arrays, automatically normalizing samples to the requested bit depth and endianness (#33).meta.custom.resolveBundledLameBinaryandresolveLameBinaryso applications can inspect or override the binary chosen at runtime.Improvements
spawnLameProcessnow drives all CLI interaction, guaranteeing consistent progress parsing and normalized warning/error messages.join(tmpdir(), "node-lame"), are created lazily, and are cleaned up automatically, even after failures.Tooling & Quality
tsupinto dual ESM/CJS bundles with generated typings.