Merge pull request #1164 from devoxx/fix/run-command-nonzero-exit-error-icon

fix: classify non-zero run_command exit as agent tool error

Author: stephanj

src/main/java/com/devoxx/genie/service/agent/AgentLoopTracker.java

@@ -157,7 +157,7 @@ private String track(@NotNull ToolExecutionRequest toolRequest, @NotNull ToolInv
      * Returns {@code true} when a tool result string represents an error by convention —
      * i.e. it starts with the "Error:" prefix used across the built-in tool executors.
      */
-    static boolean isErrorResult(@Nullable String result) {
+    public static boolean isErrorResult(@Nullable String result) {
         return result != null && result.stripLeading().startsWith("Error:");
     }
 

src/main/java/com/devoxx/genie/service/agent/tool/RunCommandToolExecutor.java

@@ -189,7 +189,10 @@ private String formatResult(int exitCode, String output) {
         if (exitCode == 0) {
             return result.isEmpty() ? "(command completed successfully with no output)" : result;
         } else {
-            return "Exit code: " + exitCode + "\n" + result;
+            // Prefix with "Error:" so AgentLoopTracker.isErrorResult() classifies a non-zero
+            // exit as TOOL_ERROR (red icon) instead of a green "success" check in the Activity
+            // panel. The exit code is kept in the message for the LLM's benefit.
+            return "Error: Command exited with code " + exitCode + "\n" + result;
         }
     }
 

src/test/java/com/devoxx/genie/service/agent/tool/RunCommandToolExecutorTest.java

@@ -1,5 +1,6 @@
 package com.devoxx.genie.service.agent.tool;
 
+import com.devoxx.genie.service.agent.AgentLoopTracker;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.SystemInfo;
 import dev.langchain4j.agent.tool.ToolExecutionRequest;
@@ -142,7 +143,7 @@ void execute_nonZeroExitCode_withOutput_returnsExitCodeAndOutput() {
                 .build();
 
         String result = executor.execute(request, null);
-        assertThat(result).contains("Exit code: 2").contains("failing");
+        assertThat(result).contains("exited with code 2").contains("failing");
     }
 
     @Test
@@ -247,7 +248,40 @@ void execute_nonZeroExitCode_returnsExitCode() {
                 .build();
 
         String result = executor.execute(request, null);
-        assertThat(result).contains("Exit code: 1");
+        assertThat(result).contains("exited with code 1");
+    }
+
+    /**
+     * Reproduces the bug where a command exiting with a non-zero code was rendered
+     * with the green "success" icon in the agent Activity panel. The icon is decided
+     * by {@link AgentLoopTracker#isErrorResult(String)}, which only flags strings
+     * beginning with "Error:". A non-zero exit must therefore produce an
+     * "Error:"-prefixed result so it is classified as TOOL_ERROR (red icon).
+     */
+    @Test
+    void execute_nonZeroExitCode_isClassifiedAsError() {
+        ToolExecutionRequest request = ToolExecutionRequest.builder()
+                .name("run_command")
+                .arguments("{\"command\": \"exit 1\"}")
+                .build();
+
+        String result = executor.execute(request, null);
+        assertThat(AgentLoopTracker.isErrorResult(result))
+                .as("Non-zero exit code must be classified as an error result")
+                .isTrue();
+    }
+
+    @Test
+    void execute_zeroExitCode_isNotClassifiedAsError() {
+        ToolExecutionRequest request = ToolExecutionRequest.builder()
+                .name("run_command")
+                .arguments("{\"command\": \"echo ok\"}")
+                .build();
+
+        String result = executor.execute(request, null);
+        assertThat(AgentLoopTracker.isErrorResult(result))
+                .as("Successful command must not be classified as an error result")
+                .isFalse();
     }
 
     @Test