Add Windows to CI matrix (#85)#86
Merged
Merged
Conversation
Adds windows-latest to the test job matrix alongside ubuntu and macos. Two small supporting changes: - fail-fast: false so a Windows-only failure doesn't kill the unix runs while we shake out platform-specific quirks. - defaults.run.shell: bash so make build and the bash-driven smoke test run consistently across all three OSes (Git Bash provides bash on windows-latest by default). Verified locally on Windows: make build produces a runnable binary named "skern", and bash scripts/smoke_test.sh ./skern passes 57/57. The smoke test already has a USERPROFILE/HOME bridge for Git Bash (scripts/smoke_test.sh:130) so no script changes are needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
devrimcavusoglu
added a commit
that referenced
this pull request
May 7, 2026
Move the [Unreleased] block to v0.3.0 dated 2026-05-07, with a focused "Breaking changes" section calling out the --from-template directory requirement (#84). Cross-link the four PRs that landed since v0.2.1 (#81, #84, #86, #87) and add a Changed entry covering the docs-site refresh that ships in this branch. Bump the corresponding version refs in AGENTS.md (current release + milestone snapshot now covers M0–M7), INSTALL.md (SKERN_VERSION pin example), docs/guide/installation.md (matching pin example), and docs/guide/index.md (current-release callout). Docs build verified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
devrimcavusoglu
added a commit
that referenced
this pull request
May 7, 2026
* Refresh docs site for v0.2.1 (eight platforms, init instructions, skill versioning) Bring the VitePress site up to date with the v0.2.0 / v0.2.1 surface that has landed since the last docs refresh: - Eight platform adapters wherever 3 were listed (index, guide, concepts diagram, reference flag enums, platforms index/comparison) and a dedicated page for each new adapter (cursor, gemini-cli, github-copilot, windsurf, continue). - `skern init --instructions` / `--tool-forming-loop` / `--target` / `--print-instructions` documented in the quick-start, agent-setup, and command reference. Agent-setup now leads with `init --instructions` instead of the manual `echo … >> AGENTS.md` recipe. - Reference reorganized: registry vs. platform command groups, full pages for `skill import`, `skill version`, `skill diff`, capacity reporting on install/uninstall, `--enforce-budget`, `--with-platforms`, batch install/uninstall. - Validation page split into errors / warnings / hints with the trigger-prefix and recommended-section hints. - Skill format page corrected to the nested `metadata.author` / `metadata.version` / `metadata.modified-by` schema and includes the import workflow. - Installation page covers macOS, Linux, and Windows (PowerShell) one-liners plus version pinning, custom install dir, source build, manual install, uninstall. - Contributing/development reflects the declarative platform spec, updated Make targets, and the `cli/instructions/` package. - Sidebar adds the new platform pages and a Writing Skills entry under Guide. Build verified with `npm run docs:build` (clean). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Cut v0.3.0: stamp CHANGELOG, bump version refs Move the [Unreleased] block to v0.3.0 dated 2026-05-07, with a focused "Breaking changes" section calling out the --from-template directory requirement (#84). Cross-link the four PRs that landed since v0.2.1 (#81, #84, #86, #87) and add a Changed entry covering the docs-site refresh that ships in this branch. Bump the corresponding version refs in AGENTS.md (current release + milestone snapshot now covers M0–M7), INSTALL.md (SKERN_VERSION pin example), docs/guide/installation.md (matching pin example), and docs/guide/index.md (current-release callout). Docs build verified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85.
Summary
windows-latestto thetestjob matrix alongsideubuntu-latestandmacos-latest. This catches Windows-specific regressions in the same PR cycle as Linux/macOS, rather than only when a contributor manually runs the build on Windows.fail-fast: falseso a Windows-only flake doesn't cancel the unix runs while we shake out any cross-platform quirks the new matrix entry surfaces.defaults.run.shell: bashfor thetestjob somake buildand the bash-driven smoke test run consistently on all three OSes —windows-latestships Git Bash so this is free.Why
We've been shipping Windows binaries since v0.2.1 (#78) and the project includes a PowerShell installer, but the test matrix was unix-only. Local verification of #81 on Windows surfaced no issues, but a Windows regression in any future change would only get caught post-release. With Windows officially supported, CI should match.
Verified locally (Windows 11)
make buildproduces a runnable binary namedskern(Go's-o skernkeeps the literal name on Windows)bash scripts/smoke_test.sh ./skern— 57/57 passTest plan
teston all three OSeswindows-latestjob is green (build + go test + smoke test)lintjob (still ubuntu-only) unaffected