Skip to content

Commit a4801bc

Browse files
authored
Merge pull request #66 from devsapp/op-logger-appcenter
optimize logger in app center
2 parents 75f03df + 482e616 commit a4801bc

5 files changed

Lines changed: 57 additions & 37 deletions

File tree

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"@alicloud/fc2": "^2.6.6",
2626
"@alicloud/fc20230330": "4.3.4",
2727
"@alicloud/pop-core": "^1.8.0",
28-
"@serverless-cd/srm-aliyun-pop-core": "^0.0.7-beta.21",
28+
"@serverless-cd/srm-aliyun-pop-core": "^0.0.8-beta.1",
2929
"@serverless-cd/srm-aliyun-ram20150501": "^0.0.2-beta.9",
3030
"@serverless-cd/srm-aliyun-sls20201230": "0.0.5-beta.3",
3131
"@serverless-devs/diff": "^0.0.3-beta.6",

src/resources/fc/index.ts

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -286,14 +286,20 @@ export default class FC extends FC_Client {
286286
throw ex;
287287
}
288288
retry += 1;
289-
290-
logger.spin(
291-
'retrying',
292-
'function',
293-
needUpdate ? 'update' : 'create',
294-
`${this.region}/${config.functionName}`,
295-
retry,
296-
);
289+
if (isAppCenter()) {
290+
const action = needUpdate ? 'update' : 'create';
291+
logger.info(
292+
`retrying ${action} function ${this.region}/${config.functionName} ${retry} times`,
293+
);
294+
} else {
295+
logger.spin(
296+
'retrying',
297+
'function',
298+
needUpdate ? 'update' : 'create',
299+
`${this.region}/${config.functionName}`,
300+
retry,
301+
);
302+
}
297303
await sleep(retryTime);
298304
}
299305
}
@@ -364,14 +370,18 @@ export default class FC extends FC_Client {
364370
throw ex;
365371
}
366372
retry += 1;
367-
368-
logger.spin(
369-
'retrying',
370-
'trigger',
371-
needUpdate ? 'update' : 'create',
372-
`${this.region}/${id}`,
373-
retry,
374-
);
373+
if (isAppCenter()) {
374+
const action = needUpdate ? 'update' : 'create';
375+
logger.info(`retrying ${action} trigger ${this.region}/${id} ${retry} times`);
376+
} else {
377+
logger.spin(
378+
'retrying',
379+
'trigger',
380+
needUpdate ? 'update' : 'create',
381+
`${this.region}/${id}`,
382+
retry,
383+
);
384+
}
375385

376386
await sleep(3);
377387
}

src/resources/sls/index.ts

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { IRegion } from '../../interface';
55
import { PROJECT, LOG_STORE } from '../../default/resources';
66
import logger from '../../logger';
77
import getUuid from 'uuid-by-string';
8+
import { isAppCenter } from '../../utils/index';
89

910
export default class Sls {
1011
static generateProjectName = (region: IRegion, accountID: string): string => {
@@ -51,18 +52,27 @@ export default class Sls {
5152
});
5253

5354
logger.debug(`init sls: ${JSON.stringify(request)}`);
54-
55-
logger.spin(
56-
'creating',
57-
'sls',
58-
`region: ${this.region}; project: ${project}; logstore: ${logstore}`,
59-
);
55+
if (isAppCenter()) {
56+
logger.info(
57+
`creating sls region: ${this.region}; project: ${project}; logstore: ${logstore}`,
58+
);
59+
} else {
60+
logger.spin(
61+
'creating',
62+
'sls',
63+
`region: ${this.region}; project: ${project}; logstore: ${logstore}`,
64+
);
65+
}
6066
await this.client.initSls(request);
61-
logger.spin(
62-
'created',
63-
'sls',
64-
`region: ${this.region}; project: ${project}; logstore: ${logstore}`,
65-
);
67+
if (isAppCenter()) {
68+
logger.info(`created sls region: ${this.region}; project: ${project}; logstore: ${logstore}`);
69+
} else {
70+
logger.spin(
71+
'created',
72+
'sls',
73+
`region: ${this.region}; project: ${project}; logstore: ${logstore}`,
74+
);
75+
}
6676
return { project, logstore };
6777
}
6878
}

src/subCommands/deploy/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ export default class Deploy {
2626

2727
constructor(readonly inputs: IInputs) {
2828
if (isAppCenter()) {
29-
logger.info(`input: ${JSON.stringify(inputs)}`);
29+
logger.info(`input props: ${JSON.stringify(inputs.props)}`);
3030
} else {
31-
logger.debug(`input: ${JSON.stringify(inputs)}`);
31+
logger.debug(`input props: ${JSON.stringify(inputs.props)}`);
3232
}
3333
this.opts = parseArgv(inputs.args, {
3434
alias: {

0 commit comments

Comments
 (0)